Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753847AbdLNRgk (ORCPT ); Thu, 14 Dec 2017 12:36:40 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:50232 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753811AbdLNRgf (ORCPT ); Thu, 14 Dec 2017 12:36:35 -0500 Date: Thu, 14 Dec 2017 17:36:24 +0000 From: Mark Brown To: Olivier Moysan Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, kernel@stlinux.com, linux-kernel@vger.kernel.org, arnaud.pouliquen@st.com, benjamin.gaignard@st.com, patches@opensource.wolfsonmicro.com Subject: Re: [RFC PATCH 2/2] ASoC: select sysclk clock from mlck clock provider in wm8994 driver Message-ID: <20171214173624.GM9788@sirena.org.uk> References: <1513270438-18523-1-git-send-email-olivier.moysan@st.com> <1513270438-18523-3-git-send-email-olivier.moysan@st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="um2V5WpqCyd73IVb" Content-Disposition: inline In-Reply-To: <1513270438-18523-3-git-send-email-olivier.moysan@st.com> X-Cookie: Every morning is a Smirnoff morning. User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 35 --um2V5WpqCyd73IVb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 14, 2017 at 05:53:58PM +0100, Olivier Moysan wrote: > When defined in device tree, MCLK1 and MCLK2 are used > as sysclk for aif1 and aif2 interfaces respectively. That's not a valid assumption as far as I remember? The AIFs can use either MCLK depending on the system configuration I think. > If clock rate is let 0, the frequency provided by > wm8994_set_dai_sysclk() is used instead. I'd expect this the other way around, if we didn't specify a frequency then read it from the input otherwise try to use clk_set_rate() to propagate things up. --um2V5WpqCyd73IVb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAloytpgACgkQJNaLcl1U h9Bgbwf/eUrYkksw12oV72tVF+EUygd2UaaGc1hsadmCZ6bMOYYZLsA8fibV/xQE n7KrG8DUrpmD1iAhDr3orh8s3TgYNAb9k99vGmnlN8s+gO0noKpYDmHprK9IqlF5 Ignnpsle3JSyAuojD//Igfckmr6zip8E1QymRme1nlQR+UtHX1ZJgC0QAum6fzFY RDG1eIqL+Cj5dl9yj9Izhj+dCsthTtIHThGuZeNtBLVz7dQ+txzWI0qISLa/yqKl 8Zfvaax2UI9I+J7cJ1fgtPxv1JN0FGX1MMKV05l1ezmBkXIKlS0JlHn0ccbYmQvE tz/jTfqM4K49ZGSMV+xLvNawMJkunw== =ZSzv -----END PGP SIGNATURE----- --um2V5WpqCyd73IVb--