Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753966AbdLNR4n (ORCPT ); Thu, 14 Dec 2017 12:56:43 -0500 Received: from mail-qt0-f181.google.com ([209.85.216.181]:44858 "EHLO mail-qt0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753711AbdLNR4l (ORCPT ); Thu, 14 Dec 2017 12:56:41 -0500 X-Google-Smtp-Source: ACJfBosHI/jUMwLelG9SxSvJLX1iB4n4IbZ2Id71OWAYdH7Okv3SXA92ccTUj4A5yc4piXpH0H4N3KosyQy+p97JgSs= MIME-Version: 1.0 In-Reply-To: References: <20171213082301.23209-1-dhaval.shah@softnautics.com> <1513167907.27409.3.camel@perches.com> <1513179572.27409.8.camel@perches.com> From: Andy Shevchenko Date: Thu, 14 Dec 2017 19:56:40 +0200 Message-ID: Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines To: Dhaval Shah Cc: Joe Perches , Philippe Ombredanne , "pali.rohar@gmail.com" , Darren Hart , Andy Shevchenko , "platform-driver-x86@vger.kernel.org" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 598 Lines: 19 On Thu, Dec 14, 2017 at 11:12 AM, Dhaval Shah wrote: > I got your point. SPDX text should be "SPDX-License-Identifier: GPL-2.0+". > Am i Right? Whatever you come up with I will apply taking into consideration the following: 1. Linus' preference over comment style. 2. Module author(s) blessing for the change. Without above on the table I would not even look into the message. P.S. And personally I'm a bit sceptical about standalone (coment) style changes. I would rather not to apply anything like this without real need. -- With Best Regards, Andy Shevchenko