Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753870AbdLNSCs (ORCPT ); Thu, 14 Dec 2017 13:02:48 -0500 Received: from mail-qk0-f178.google.com ([209.85.220.178]:45357 "EHLO mail-qk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753698AbdLNSCq (ORCPT ); Thu, 14 Dec 2017 13:02:46 -0500 X-Google-Smtp-Source: ACJfBosijFAT2/9ziFLSfJ+34McVve3y6ManeSyftw2R5ZM1QFQNx8j7EPo6BwtliqJeGLYI7KzVHm43zTAv0nCdiZU= MIME-Version: 1.0 In-Reply-To: <20171213083053.mywa4bgv56daxud6@pali> References: <20171213082354.23273-1-dhaval.shah@softnautics.com> <20171213083053.mywa4bgv56daxud6@pali> From: Andy Shevchenko Date: Thu, 14 Dec 2017 20:02:45 +0200 Message-ID: Subject: Re: [PATCH] platform/x86: dell-smo8800: Possible unnecessary 'out of memory' message To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Dhaval Shah , "dvhart@infradead.org" , Andy Shevchenko , Platform Driver , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBEI2tfS024062 Content-Length: 662 Lines: 17 On Wed, Dec 13, 2017 at 10:30 AM, Pali Rohár wrote: > On Wednesday 13 December 2017 13:53:54 Dhaval Shah wrote: >> Removed Possible unnecessary 'out of memory' message checkpatch warnings. >> Issue found by checkpatch. >> - dev_err(&device->dev, "failed to allocate device data\n"); > > Hi! Any particular reason for removing error message? If you look into drivers/base/dd.c (real_probe() function IIRC) it issues a warning when probe fails with error code. So, basically all error messages in ->probe() are redundant (except maybe those that prints more than error message itself). -- With Best Regards, Andy Shevchenko