Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753928AbdLNSPc (ORCPT ); Thu, 14 Dec 2017 13:15:32 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:40641 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753778AbdLNSP3 (ORCPT ); Thu, 14 Dec 2017 13:15:29 -0500 X-Google-Smtp-Source: ACJfBove8krFuBXU1ZAYzYhyFickbxarHOLEqDH/iCQ+HTq+4BoQgZtJc2J+SsihvHcPXzjNuoGK/6udvdDvnC/5JkI= MIME-Version: 1.0 In-Reply-To: <1513268971-13518-3-git-send-email-oleksandrs@mellanox.com> References: <1513268971-13518-1-git-send-email-oleksandrs@mellanox.com> <1513268971-13518-3-git-send-email-oleksandrs@mellanox.com> From: Philippe Ombredanne Date: Thu, 14 Dec 2017 19:14:47 +0100 Message-ID: Subject: Re: [patch v14 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver To: Oleksandr Shamray Cc: Greg Kroah-Hartman , Arnd Bergmann , LKML , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , OpenBMC Maillist , joel@jms.id.au, =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= , Tobias Klauser , linux-serial@vger.kernel.org, vadimp@mellanox.com, system-sw-low-level@mellanox.com, Rob Herring , openocd-devel-owner@lists.sourceforge.net, linux-api@vger.kernel.org, "David S. Miller" , Mauro Carvalho Chehab , Jiri Pirko Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1061 Lines: 37 Oleksandr, On Thu, Dec 14, 2017 at 5:29 PM, Oleksandr Shamray wrote: > Driver adds support of Aspeed 2500/2400 series SOC JTAG master controller. > > Driver implements the following jtag ops: > - freq_get; > - freq_set; > - status_get; > - idle; > - xfer; > > It has been tested on Mellanox system with BMC equipped with > Aspeed 2520 SoC for programming CPLD devices. > > Signed-off-by: Oleksandr Shamray > Signed-off-by: Jiri Pirko > Acked-by: Arnd Bergmann > --- > v13->v14 > Comments pointed by Philippe Ombredanne > - Change style of head block comment from /**/ to // > > v12->v13 > Comments pointed by Philippe Ombredanne > - Change jtag-aspeed.c licence type to > SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note > and reorder line with license in description Thanks for the SPDX tags! for this part you have my ack: Acked-by: Philippe Ombredanne