Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754140AbdLNS16 (ORCPT ); Thu, 14 Dec 2017 13:27:58 -0500 Received: from mail-it0-f48.google.com ([209.85.214.48]:44529 "EHLO mail-it0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753722AbdLNS14 (ORCPT ); Thu, 14 Dec 2017 13:27:56 -0500 X-Google-Smtp-Source: ACJfBosXn51UGlVGJUOpaJqbLQp15yGflTfILby4FL2lQdtzVYZdHhwcI8bR/HgLaiGdX2YP8o9N6EaA9DlmearE0iE= MIME-Version: 1.0 In-Reply-To: <1513267513-11562-2-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1513267513-11562-1-git-send-email-yanhaishuang@cmss.chinamobile.com> <1513267513-11562-2-git-send-email-yanhaishuang@cmss.chinamobile.com> From: William Tu Date: Thu, 14 Dec 2017 10:27:15 -0800 Message-ID: Subject: Re: [PATCH 2/2] ip6_gre: fix error path when ip6erspan_rcv failed To: Haishuang Yan Cc: "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , linux-kernel@vger.kernel.org, Linux Kernel Network Developers Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 484 Lines: 12 On Thu, Dec 14, 2017 at 8:05 AM, Haishuang Yan wrote: > Same as ipv4 code, when ip6erspan_rcv call return PACKET_REJECT, we > should call icmpv6_send to send icmp unreachable message in error path. > > Fixes: 5a963eb61b7c ("ip6_gre: Add ERSPAN native tunnel support") > Cc: William Tu > Signed-off-by: Haishuang Yan > --- Looks good to me. Thanks. Acked-by: William Tu