Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754008AbdLNSaG (ORCPT ); Thu, 14 Dec 2017 13:30:06 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:34260 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753677AbdLNSaF (ORCPT ); Thu, 14 Dec 2017 13:30:05 -0500 Date: Thu, 14 Dec 2017 13:30:03 -0500 (EST) Message-Id: <20171214.133003.2081913730304316242.davem@davemloft.net> To: sean.wang@mediatek.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 net-next 0/3] add VLAN support to DSA MT7530 From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 14 Dec 2017 10:30:04 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vBEIUlEb032561 Content-Length: 1474 Lines: 32 From: Date: Wed, 13 Dec 2017 12:01:10 +0800 > From: Sean Wang > > Changes since v1: > - fix up the typo > - prefer ordering declarations longest to shortest > - update that vlan_prepare callback should not change any state > - use lower case letter for function naming > > The patchset extends DSA MT7530 to VLAN support through filling required > callbacks in patch 1 and merging the special tag with VLAN tag in patch 2 > for allowing that the hardware can handle these packets with VID from the > CPU port. This doesn't even compile: drivers/net/dsa/mt7530.c: In function ?mt7530_port_vlan_add?: drivers/net/dsa/mt7530.c:1131:6: warning: unused variable ?ret? [-Wunused-variable] int ret; ^~~ drivers/net/dsa/mt7530.c: At top level: drivers/net/dsa/mt7530.c:1324:23: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] .port_vlan_prepare = mt7530_port_vlan_prepare, ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/dsa/mt7530.c:1324:23: note: (near initialization for ?mt7530_switch_ops.port_vlan_prepare?) drivers/net/dsa/mt7530.c:1325:20: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] .port_vlan_add = mt7530_port_vlan_add, ^~~~~~~~~~~~~~~~~~~~ drivers/net/dsa/mt7530.c:1325:20: note: (near initialization for ?mt7530_switch_ops.port_vlan_add?) cc1: some warnings being treated as errors