Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754156AbdLNTEf (ORCPT ); Thu, 14 Dec 2017 14:04:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:59620 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753743AbdLNTEd (ORCPT ); Thu, 14 Dec 2017 14:04:33 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27F8B218DC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh+dt@kernel.org X-Google-Smtp-Source: ACJfBouYYbJaIVodV4amQUVSqHuY5My4POjLw4I5FaPOyHi74vS8YgzWe82QQXGO9rycQXCGtSaq0OWGFP9jo2vYlNs= MIME-Version: 1.0 In-Reply-To: <20171214165344.27795-1-malat@debian.org> References: <20171214165344.27795-1-malat@debian.org> From: Rob Herring Date: Thu, 14 Dec 2017 13:04:11 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arc: dts: Remove leading 0x and 0s from bindings notation To: Mathieu Malaterre Cc: Mark Rutland , Vineet Gupta , Alexey Brodkin , "devicetree@vger.kernel.org" , arcml , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1220 Lines: 32 On Thu, Dec 14, 2017 at 10:53 AM, Mathieu Malaterre wrote: > Improve the DTS files by removing all the leading "0x" and zeros to fix the > following dtc warnings: > > Warning (unit_address_format): Node /XXX unit name should not have leading "0x" > > and > > Warning (unit_address_format): Node /XXX unit name should not have leading 0s > > Converted using the following command: > > find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -E -i -e "s/@0x([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" -e "s/@0+([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" {} + > > For simplicity, two sed expressions were used to solve each warnings separately. > > To make the regex expression more robust a few other issues were resolved, > namely setting unit-address to lower case, and adding a whitespace before the > the opening curly brace: > > https://elinux.org/Device_Tree_Linux#Linux_conventions > > This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation") > > Reported-by: David Daney > Suggested-by: Rob Herring > Signed-off-by: Mathieu Malaterre > --- For the series, Reviewed-by: Rob Herring