Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753180AbdLNU11 (ORCPT ); Thu, 14 Dec 2017 15:27:27 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:46932 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752455AbdLNU1Y (ORCPT ); Thu, 14 Dec 2017 15:27:24 -0500 Date: Thu, 14 Dec 2017 21:27:26 +0100 From: Greg Kroah-Hartman To: "Ghannam, Yazen" Cc: Ben Hutchings , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Matt Fleming , Borislav Petkov , Andrew Morton , Andy Lutomirski , Andy Lutomirski , Ard Biesheuvel , Borislav Petkov , Brian Gerst , Dave Jones , Denys Vlasenko , "H. Peter Anvin" , Linus Torvalds , Peter Zijlstra , Sai Praneeth Prakhya , Stephen Smalley , Thomas Gleixner , Toshi Kani , "linux-efi@vger.kernel.org" , Ingo Molnar , Alex Thorlton Subject: Re: [PATCH 4.4 05/27] x86/efi: Build our own page table structures Message-ID: <20171214202726.GA32443@kroah.com> References: <20171204155942.271814507@linuxfoundation.org> <20171204155942.482436478@linuxfoundation.org> <1512686629.18523.217.camel@codethink.co.uk> <20171210212651.GA18497@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2802 Lines: 63 On Tue, Dec 12, 2017 at 05:24:32PM +0000, Ghannam, Yazen wrote: > > -----Original Message----- > > From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] > > Sent: Sunday, December 10, 2017 4:27 PM > > To: Ben Hutchings ; Ghannam, Yazen > > > > Cc: linux-kernel@vger.kernel.org; stable@vger.kernel.org; Matt Fleming > > ; Borislav Petkov ; Andrew > > Morton ; Andy Lutomirski > > ; Andy Lutomirski ; Ard Biesheuvel > > ; Borislav Petkov ; Brian Gerst > > ; Dave Jones ; Denys > > Vlasenko ; H. Peter Anvin ; Linus > > Torvalds ; Peter Zijlstra > > ; Sai Praneeth Prakhya > > ; Stephen Smalley ; > > Thomas Gleixner ; Toshi Kani ; > > linux-efi@vger.kernel.org; Ingo Molnar ; Ghannam, > > Yazen ; Alex Thorlton > > Subject: Re: [PATCH 4.4 05/27] x86/efi: Build our own page table structures > > > > On Thu, Dec 07, 2017 at 10:43:49PM +0000, Ben Hutchings wrote: > > > On Mon, 2017-12-04 at 16:59 +0100, Greg Kroah-Hartman wrote: > > > > 4.4-stable review patch.??If anyone has any objections, please let me > > know. > > > > > > > > ------------------ > > > > > > > > From: Matt Fleming > > > > > > > > commit 67a9108ed4313b85a9c53406d80dc1ae3f8c3e36 upstream. > > > [...] > > > > > > It looks like this will cause regressions unless you also apply: > > > > > > 21cdb6b56843 x86/mm: Page align the '_end' symbol to avoid pfn > > conversion bugs > > > b61a76f8850d x86/efi: Map RAM into the identity page table for mixed > > mode > > > 753b11ef8e92 x86/efi: Setup separate EFI page tables in kexec paths > > > > > > and possibly also: > > > > > > 08914f436bdd x86/platform/UV: Bring back the call to map_low_mmrs in > > uv_system_init > > > 683ad8092cd2 x86/efi: Fix 7-parameter efi_call()s > > > 80e75596079f efi: Convert efi_call_virt() to efi_call_virt_pointer() > > > d1be84a232e3 x86/uv: Update uv_bios_call() to use efi_call_virt_pointer() > > > > Ugh, that's a mess. Yazen is the one who reported this patch, and 2 > > others, were needed to resolve an issue on their hardware. > > > > Yazen, any thoughts here? Should I just revert the 3 patches, or do you > > also feel I need all 7 of these to ensure everything works properly? > > > > I think it's okay to revert the 3 patches. Ugh, messy. Ok, all now reverted. Thanks Ben for the review, much appreciated. greg k-h