Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753269AbdLNUpA (ORCPT <rfc822;w@1wt.eu>);
        Thu, 14 Dec 2017 15:45:00 -0500
Received: from mail.free-electrons.com ([62.4.15.54]:46311 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752600AbdLNUoz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 14 Dec 2017 15:44:55 -0500
Date: Thu, 14 Dec 2017 21:44:42 +0100
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>, Przemyslaw Sroka <psroka@cadence.com>,
        Arkadiusz Golec <agolec@cadence.com>,
        Alan Douglas <adouglas@cadence.com>,
        Bartosz Folta <bfolta@cadence.com>, Damian Kos <dkos@cadence.com>,
        Alicja Jurasik-Urbaniak <alicja@cadence.com>,
        Cyprian Wronka <cwronka@cadence.com>,
        Suresh Punnoose <sureshp@cadence.com>,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        Nishanth Menon <nm@ti.com>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Vitor Soares <Vitor.Soares@synopsys.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 6/7] i3c: master: Add driver for Cadence IP
Message-ID: <20171214214442.55902041@bbrezillon>
In-Reply-To: <8245f2de-eb0a-319b-8f45-d8d5dac36239@infradead.org>
References: <20171214151610.19153-1-boris.brezillon@free-electrons.com>
        <20171214151610.19153-7-boris.brezillon@free-electrons.com>
        <d0685c1d-a3ed-b3c1-7e3f-b69b02e8a7be@infradead.org>
        <20171214211722.1c2f269d@bbrezillon>
        <8245f2de-eb0a-319b-8f45-d8d5dac36239@infradead.org>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 937
Lines: 30

On Thu, 14 Dec 2017 12:25:14 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:

> On 12/14/2017 12:17 PM, Boris Brezillon wrote:
> >>> +	events.events = I3C_CCC_EVENT_HJ | I3C_CCC_EVENT_MR;
> >>> +	ret = i3c_master_enec_locked(m, I3C_BROADCAST_ADDR, &events);
> >>> +	if (ret)
> >>> +		pr_info("Failed to re-enable H-J");    
> >> 		Not very good info...  
> > What do you mean? Is it the H-J that bothers you (I can replace it by
> > 'Hot-Join'), or is it something else?  
> 
> Who is the message for?  If it's for developers, you could use
> pr_debug().  If it's for users, it needs more clarity.

I think it's of interest to anyone including users. If we fail to
re-enable Hot-Join that means hotplug is no longer working which is
a bad news.

> 
> Does it print the source of the message? (module name e.g.)

I could replace it by

	dev_err(m->parent, "Failed to re-enable Hot-Join");



> and yes, Hot-Join would be better IMO.
>