Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753984AbdLNVU2 (ORCPT ); Thu, 14 Dec 2017 16:20:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:60958 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753483AbdLNVU0 (ORCPT ); Thu, 14 Dec 2017 16:20:26 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7049A218DC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=luto@kernel.org X-Google-Smtp-Source: ACJfBouh8m1MMTx4HOXuiF0u15h6Pts5LnwukJoEg0bmhpW+cNdd4oK9F659EVGJNyeeZrwiMORjjC/BdAI+atUB8eg= MIME-Version: 1.0 In-Reply-To: References: <2809506.pL8kVbvXcY@aspire.rjw.lan> <20171210213804.GA4660@amd> <76028A95-1CE1-49AA-9929-9C15FFC520EB@amacapital.net> <151331264.Sjvx2oHGGq@aspire.rjw.lan> <20171214203815.GA29972@amd> From: Andy Lutomirski Date: Thu, 14 Dec 2017 13:20:05 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] Fix resume on x86-32 machines To: Linus Torvalds Cc: Pavel Machek , "Rafael J. Wysocki" , Andrew Lutomirski , Zhang Rui , Thomas Gleixner , Jarkko Nikula , Linux Kernel Mailing List , "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1393 Lines: 30 On Thu, Dec 14, 2017 at 12:47 PM, Linus Torvalds wrote: > On Thu, Dec 14, 2017 at 12:38 PM, Pavel Machek wrote: >> >> But given this is already "regression fix for x86-64 caused regression >> on x86-32", I really believe we should merge trivial fix now, and do >> the cleanups / nicer fixes sometime later? > > The fix patch was already posted, but in another thread (confusingly > with _almost_ the same subject: "Re: Linux 4.15-rc2: Regression in > resume from ACPI S3"). > > Here: > > https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/fixes > > but it hasn't actually gotten to me yet (I think Luto made a new > version where he split it up into three smaller patches, and I'm > assuming it's in one of the -tip trees heading for me asap). > > All the x86 people have been insanely busy with the crazy page table > isolation patches, that probably is slowing down things. But I was > expecting to get the -tip tree pulls tomorrow (.. because.. Friday. > It's my busiest day of the week because everybody wants to get their > work out before the weekend). Nah, it's that I was busy with the stupid PTI stuff, and the original version of the patch didn't compile on some configurations. I've tested the version I just sent for suspend-to-ram and suspend-to-disk on 32-bit and 64-bit in a couple of configurations.