MIME-Version: 1.0
In-Reply-To: <1513286332.18523.281.camel@codethink.co.uk>
References: <20171207181306.5623-1-deepa.kernel@gmail.com> <20171207181306.5623-2-deepa.kernel@gmail.com>
 <1513286249.18523.280.camel@codethink.co.uk> <1513286332.18523.281.camel@codethink.co.uk>
From: Deepa Dinamani <deepa.kernel@gmail.com>
Date: Thu, 14 Dec 2017 13:44:35 -0800
Message-ID: <CABeXuvpGRtp2fR3yW-eDyCOYpWfLReNytpew7kXD0xOxTEnZZw@mail.gmail.com>
Subject: Re: [Y2038] [PATCH v4 1/4] uinput: Use monotonic times for uinput timestamps.
To: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        y2038 Mailman List <y2038@lists.linaro.org>,
        Peter Hutterer <peter.hutterer@who-t.net>,
        Arnd Bergmann <arnd@arndb.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1335
Lines: 31

On Thu, Dec 14, 2017 at 1:18 PM, Ben Hutchings
<ben.hutchings@codethink.co.uk> wrote:
> On Thu, 2017-12-14 at 21:17 +0000, Ben Hutchings wrote:
>> On Thu, 2017-12-07 at 10:13 -0800, Deepa Dinamani wrote:
>> > struct timeval which is part of struct input_event to
>> > maintain the event times is not y2038 safe.
>> >
>> > Real time timestamps are also not ideal for input_event
>> > as this time can go backwards as noted in the patch
>> > a80b83b7b8 by John Stultz.
>> >
>> > The patch switches the timestamps to use monotonic time
>> > from realtime time. This is assuming no one is using
>> > absolute times from these timestamps.
>>
>> Why is this change not opt-in, as for evdev?  I assume there were
>> compatibility reasons for not changing evdev's clock by default, so I
>> would expect them to apply to uinput as well.  (But I'm also prepared
>> to believe that user-space is now generally compatible with and would
>> prefer monotonic time from all input devices.)
>
> Never mind, I've gone back and seen Arnd's comments about compatibility
> on v3.  It might be worth copying those into the commit message though.

Commit message already talks about this assumption?:

The patch switches the timestamps to use monotonic time
from realtime time. This is assuming no one is using
absolute times from these timestamps.

-Deepa