Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753882AbdLNVox (ORCPT ); Thu, 14 Dec 2017 16:44:53 -0500 Received: from mail-ua0-f196.google.com ([209.85.217.196]:39300 "EHLO mail-ua0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753702AbdLNVou (ORCPT ); Thu, 14 Dec 2017 16:44:50 -0500 X-Google-Smtp-Source: ACJfBouV1uXtDQmJI6A1IhY4MN6IZwHtsEdrAPkq7SmGN7a711ibpSPc/R6IVsW5UBOFWMtj0gIyXn5dtIhtCLsFaMY= MIME-Version: 1.0 In-Reply-To: References: <20171213232122.5ztmwume5kylh4mz@dtor-ws> From: Dmitry Torokhov Date: Thu, 14 Dec 2017 13:44:49 -0800 Message-ID: Subject: Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink To: Casey Leedom Cc: Greg Kroah-Hartman , Eric Dumazet , Eric Dumazet , Tariq Toukan , "David S . Miller" , Komali Katari , "Luis R. Rodriguez" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1122 Lines: 31 On Thu, Dec 14, 2017 at 1:38 PM, Casey Leedom wrote: > | From: Dmitry Torokhov > | Sent: Thursday, December 14, 2017 12:32 PM > | > | As far as I can see Eric's patch is landed in 4.15-rc1 so I do not > | think we need this patch in .14. > > Except that Komali's bisect showed that the bug occured with kernel.org: > 1455cf8dbfd06aa7651dcfccbadb7a093944ca65 which went in on July 19, 2017 which looks like it may even have made it into 4.13 ... No, it is not in 4.13, but it is in 4.14: dtor@dtor-ws:~/kernel/linus $ git describe --contains 1455cf8dbfd06aa7651dcfccbadb7a093944ca65 v4.14-rc1~147^2~16^2~6 This commit was causing issues because of unfortunate udev rules that tried to load modules on any uevent except "remove" (we've fixed it to only act on "add" now). We also added workaround for it: dtor@dtor-ws:~/kernel/linus $ git describe --contains 6878e7de6af726de47f9f3bec649c3f49e786586 v4.14-rc4~36^2~4 Unfortunately that workaround got broken with Eric's refactoring that went into 4.15 and is being fixed with this patch. Hope this helps. -- Dmitry