Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754313AbdLNWur (ORCPT ); Thu, 14 Dec 2017 17:50:47 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:59733 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754091AbdLNWun (ORCPT ); Thu, 14 Dec 2017 17:50:43 -0500 Date: Thu, 14 Dec 2017 23:50:41 +0100 From: Pavel Machek To: Dan Murphy Cc: Jacek Anaszewski , robh+dt@kernel.org, mark.rutland@arm.com, rpurdie@rpsys.net, sakari.ailus@iki.fi, laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH] leds: as3645a: Fix checkpatch warnings Message-ID: <20171214225041.GB10957@amd> References: <20171212215011.30066-1-dmurphy@ti.com> <98df06ef-9ee4-02b1-6d6b-f10b911a8d71@gmail.com> <799ae164-701a-87ce-fadf-8278f01c10d6@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9zSXsLTf0vkW971A" Content-Disposition: inline In-Reply-To: <799ae164-701a-87ce-fadf-8278f01c10d6@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1583 Lines: 62 --9zSXsLTf0vkW971A Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2017-12-13 14:49:38, Dan Murphy wrote: > Pavel and Laurent >=20 > On 12/13/2017 02:43 PM, Jacek Anaszewski wrote: > > Dan, > >=20 > > On 12/13/2017 09:41 PM, Dan Murphy wrote: > >> Jacek > >> > >> On 12/13/2017 02:29 PM, Jacek Anaszewski wrote: > >>> Hi Dan, > >>> > >>> checkpatch.pl doesn't want to be mentioned in the patch subject :-) > >>> > >> > >> Ack > >> > >>> "WARNING: A patch subject line should describe the change not the tool > >>> that found it" > >>> > >>> Preferably I'd see two separate patches. > >>> > >> > >> So you want me to split them up? I have no issue with that. > >=20 > > Yeah, it will be easier to come up with concise but meaningful > > subjects. > >=20 >=20 > When I split these up can I add your Acked-by to each patch or would you = prefer to resend your > Acked-by for each patch? You can keep the ack... =2E..and my preference would be for trivial fixes like these to be just applied. No need to resend 3 versions etc... Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --9zSXsLTf0vkW971A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlozAEEACgkQMOfwapXb+vIyXACfSVhVugYRzHhyzMBXcA6WlABY MDgAn0FvwoID66vSlMQicT+pXtejyZOA =7s17 -----END PGP SIGNATURE----- --9zSXsLTf0vkW971A--