Subject: Re: [PATCH 1/2][RFC]Ktest: Add email support
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, dhaval.giani@oracle.com,
        "John 'Warthog9' Hawley" <warthog9@kernel.org>
References: <20171120173738.34823-2-tianyang.chen@oracle.com>
 <d265a564-5241-5a90-d712-149b92319285@oracle.com>
 <20171214183914.7d911500@gandalf.local.home>
From: Tim Tianyang Chen <tianyang.chen@oracle.com>
Organization: Oracle Corporation
Message-ID: <7def72e8-d30d-b9c0-bb31-1263cfcadfd0@oracle.com>
Date: Thu, 14 Dec 2017 16:11:25 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171214183914.7d911500@gandalf.local.home>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 904
Lines: 20

Thanks for the review Steven!
> First comment is that the numbered patches need to be a reply to the
> cover patch (that is patches 1/2 and 2/2 need to be replies of 0/2).
> Otherwise, my mailer loses them, because I always have my email sorted
> by threads, and a reply to 0/2 will move it away from the other patches
> if the other patches are not replies.
Not sure what happened. I used --thread option for git send-email, and 
in thunderbird I can see all the patches in one thread replying to 0/2.
> Hmm, I'm thinking it doesn't get sent when we hit Ctrl-C. Or at last
> have these as options to when to send them.
>
> I think by default, it should only send when finished, or failed. But
> have options like:
>
> 	EMAIL_WHEN_STARTED, EMAIL_WHEN_CANCELED (both default false)
> 	EMAIL_WHEN_FINIHSED and EMAIL_ON_ERROR (both default true).
Yeah. It's a good idea to add them as options.

Thanks,
Tim