Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754551AbdLOAbj (ORCPT ); Thu, 14 Dec 2017 19:31:39 -0500 Received: from imap1.codethink.co.uk ([176.9.8.82]:35576 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754431AbdLOAbg (ORCPT ); Thu, 14 Dec 2017 19:31:36 -0500 Message-ID: <1513297891.18523.295.camel@codethink.co.uk> Subject: Re: [Y2038] [PATCH v2 10/10] nanosleep: change time types to safe __kernel_* types From: Ben Hutchings To: Deepa Dinamani , tglx@linutronix.de, john.stultz@linaro.org Cc: y2038@lists.linaro.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de Date: Fri, 15 Dec 2017 00:31:31 +0000 In-Reply-To: <20171127193037.8711-11-deepa.kernel@gmail.com> References: <20171127193037.8711-1-deepa.kernel@gmail.com> <20171127193037.8711-11-deepa.kernel@gmail.com> Organization: Codethink Ltd. Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 824 Lines: 35 On Mon, 2017-11-27 at 11:30 -0800, Deepa Dinamani wrote: [...] > @@ -15,9 +16,7 @@ struct pollfd; >  enum timespec_type { >   TT_NONE = 0, >   TT_NATIVE = 1, > -#ifdef CONFIG_COMPAT >   TT_COMPAT = 2, > -#endif >  }; >   >  /* > @@ -40,10 +39,8 @@ struct restart_block { >   clockid_t clockid; >   enum timespec_type type; >   union { > - struct timespec __user *rmtp; > -#ifdef CONFIG_COMPAT > + struct __kernel_timespec __user *rmtp; >   struct compat_timespec __user *compat_rmtp; > -#endif >   }; >   u64 expires; >   } nanosleep; [...] The deletions of #ifdef and #endif here seem to belong in patch #6, as that's the one that changes the condition for the compat nanosleep implementation which uses the compat_rmtp field. Ben. -- Ben Hutchings Software Developer, Codethink Ltd.