MIME-Version: 1.0
In-Reply-To: <20171214141836.7ndd6i3qaef36e2o@starbug-vm.ie.oracle.com>
References: <1513259818-11419-1-git-send-email-wanpeng.li@hotmail.com> <20171214141836.7ndd6i3qaef36e2o@starbug-vm.ie.oracle.com>
From: Wanpeng Li <kernellwp@gmail.com>
Date: Fri, 15 Dec 2017 09:45:27 +0800
Message-ID: <CANRm+CzTS7czh9JD35x=LfsL2YaVMSSAdVwwe=MtU2YMoY6Bxw@mail.gmail.com>
Subject: Re: [PATCH v3] KVM: X86: Fix stack-out-of-bounds read in write_mmio
To: Wanpeng Li <kernellwp@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Christoffer Dall <christoffer.dall@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 747
Lines: 22

2017-12-14 22:18 GMT+08:00 Darren Kenny <darren.kenny@oracle.com>:
> Hi,
>
> I'm wondering about the change to trace_kvm_mmio() here, since it
> doesn't appear to be changing the use of it in
> virt/kvm/arm/mmio.c, e.g:
>
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/virt/kvm/arm/mmio.c#n114
>
> which seems to be still using it with a data value rather than a
> pointer like you've changed it to in the header.
>
> Should that also be modified to match? As it is, it would appear to
> cause a compilation error on ARM (though I've not confirmed).

Yeah, fix it in v4, https://lkml.org/lkml/2017/12/14/954 however, I
don't have an ARM environment to compile it though the change is very
simple.

Regards,
Wanpeng Li