Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754767AbdLOCk0 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 14 Dec 2017 21:40:26 -0500
Received: from mout.gmx.net ([212.227.17.20]:49157 "EHLO mout.gmx.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754594AbdLOCkY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 14 Dec 2017 21:40:24 -0500
Message-ID: <1513305570.893.7.camel@gmx.de>
Subject: Re: [PATCH 2/6] blk-mq: replace timeout synchronization with a RCU
 and generation based scheme
From: Mike Galbraith <efault@gmx.de>
To: Peter Zijlstra <peterz@infradead.org>,
        Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "kernel-team@fb.com" <kernel-team@fb.com>,
        "oleg@redhat.com" <oleg@redhat.com>, "hch@lst.de" <hch@lst.de>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "jianchao.w.wang@oracle.com" <jianchao.w.wang@oracle.com>,
        "osandov@fb.com" <osandov@fb.com>, "tj@kernel.org" <tj@kernel.org>
Date: Fri, 15 Dec 2017 03:39:30 +0100
In-Reply-To: <20171214215404.GK3326@worktop>
References: <20171212190134.535941-1-tj@kernel.org>
         <20171212190134.535941-3-tj@kernel.org> <1513277469.2475.43.camel@wdc.com>
         <20171214202042.GG3326@worktop> <1513287766.2475.73.camel@wdc.com>
         <20171214215404.GK3326@worktop>
Content-Type: text/plain; charset="ISO-8859-15"
X-Mailer: Evolution 3.20.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:SGO9UaZZ9oJvlAVa29y5FQxhQeS9mW6gOSneQmrl5yr95xTwu2d
 Ip04pCYhpXC7ZcjlM3n72XDN0FkqN56+xrqsB9wWsbW+XHNhdoB+bVYzlFspZVKKoZcl29R
 J4Un6ya7tbYkiOYHdrp2k407m5U8qKUrXsNY6SF3XCwoTU67ourh4nRZWaW9t2ObylGN+md
 PhZr7eYEOPhtlF2R9xWOA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:cSwpjtRgHcc=:+ojJTkxj8LMpmtF8wA9HVp
 pM4dVWgnWzvZs6y8lywLu0mBzhsVA+G1AXyo9bOmGy2r3AGnT1OaV18g6gLDJ3yWGDTeBxC8y
 lg8SUlBkdscfW+zZXZzVSLXAuvt1ZPY29jBvIYDH5fMxHxycTDxN5T4QKt9PCJ9DSWXlzG5dw
 sGgSs74r3M7n2+4kPejHaxg1Gek4UjkmyD+1xcjjK03W8yY8AUs+izpXKfmwxHpZTVj6xzG7+
 UCJvkSkUpNCdn/hNRJOK1u2bNHoJwc732wx9LYNc79wXE0iq5NUiIIa/Mor4hf0byZjvIi6pV
 hnPL/rriL3fAesa/o4ne6elq3Pl6WQUn9xpQHng3E/iZfUoKnztRFl9uOTXf4E8vT+olLQIoW
 jXHjUG38fsv82hOCQ2XIEW6ntlenqlKoVmeAq+EPnJqoJHQ/EERDfOkOWmrFNR+DSx5q1bKGj
 E1Q97zUO5khtqGb1+7UytZODgef6tYsXEOthnoVTDlb9Ugl+FCDSZBdV2Itaqu5qa2RYNt3eD
 hgF5gJ2efrvO7AW+wnfHrYg0sga5KaJudP2/xiloJUYAiu9EMoy8Gv8es1xLdc4hSpLQ9PH1Z
 h1mQffuTbFodQxMRo4AudMKO0heD15j9hQHg627MzGyauzolSpDdUFER43PhIqvz8gZxRnZRu
 145MiqpVsAnOCh4363zvYO9ykLULibGn7Ubf7+x+Q4TblAMVIMOA94LFP6lJCjO01Pu3QCYin
 CFEJ8InBNa8B5//hBbAh4fRqTjHomfAlqOPwA0SAm/RKWLKnvCHY1mriEqAP9nuMAUStwlccq
 ZPgkEbH509ho2U56zoeJkZlqOD+0py4SrpogpnXaHFdVtqmixI=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1044
Lines: 33

On Thu, 2017-12-14 at 22:54 +0100, Peter Zijlstra wrote:
> On Thu, Dec 14, 2017 at 09:42:48PM +0000, Bart Van Assche wrote:
> 
> > Some time ago the block layer was changed to handle timeouts in thread context
> > instead of interrupt context. See also commit 287922eb0b18 ("block: defer
> > timeouts to a workqueue").
> 
> That only makes it a little better:
> 
> 	Task-A					Worker
> 
> 	write_seqcount_begin()
> 	blk_mq_rw_update_state(rq, IN_FLIGHT)
> 	blk_add_timer(rq)
> 	<timer>
> 		schedule_work()
> 	</timer>
> 	<context-switch to worker>
> 						read_seqcount_begin()
> 							while(seq & 1)
> 								cpu_relax();
> 
> 
> Now normally this isn't fatal because Worker will simply spin its entire
> time slice away and we'll eventually schedule our Task-A back in, which
> will complete the seqcount and things will work.
> 
> But if, for some reason, our Worker was to have RT priority higher than
> our Task-A we'd be up some creek without no paddles.

Most kthreads, including kworkers, are very frequently SCHED_FIFO here.

	-Mike