Date: Fri, 15 Dec 2017 09:53:20 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Andreas Platschek <andreas.platschek@opentech.at>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org, sil2review@lists.osadl.org
Subject: Re: [PATCH v3] dmaengine: fsl-edma: disable clks on all error paths
Message-ID: <20171215042319.GB18649@localhost>
References: <20171214115051.27915-1-andreas.platschek@opentech.at>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171214115051.27915-1-andreas.platschek@opentech.at>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 708
Lines: 18

On Thu, Dec 14, 2017 at 12:50:51PM +0100, Andreas Platschek wrote:
> Previously enabled clks are only disabled if clk_prepare_enable() fails.
> However, there are other error paths were the previously enabled
> clocks are not disabled.
> 
> To fix the problem, fsl_disable_clocks() now takes the number of clocks
> that shall be disabled + unprepared. For existing calls were all clocks
> were already successfully prepared + enabled, DMAMUX_NR is passed to
> disable + unprepare all clocks.
> 
> In error paths were only some clocks were successfully prepared +
> enabled the loop counter is passed, in order to disable + unprepare
> all successfully prepared + enabled clocks.

Applied, thanks

-- 
~Vinod