From: Dhaval Shah <dhaval.shah@softnautics.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
CC: Matthew Garrett <mjg59@srcf.ucam.org>,
        =?iso-8859-1?Q?Pali_Roh=E1r?= <pali.rohar@gmail.com>,
        Andy Shevchenko <andy@infradead.org>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] platform/x86: dell-laptop: All the warnings are
 resolved.
Thread-Topic: [PATCH 0/3] platform/x86: dell-laptop: All the warnings are
 resolved.
Thread-Index: AQHTc+pbABZ3jTzdn0SpGF5rErjrYqNDIt2AgAC7z14=
Date: Fri, 15 Dec 2017 05:15:15 +0000
Message-ID: <BM1PR0101MB14443B072F71BF4CB1F85100E60B0@BM1PR0101MB1444.INDPRD01.PROD.OUTLOOK.COM>
References: <20171213081309.22851-1-dhaval.shah@softnautics.com>,<CAHp75VfTO9iCVFhddb1WHCL8RPKTVT7OhdOwvHJNy60V93wy0A@mail.gmail.com>
In-Reply-To: <CAHp75VfTO9iCVFhddb1WHCL8RPKTVT7OhdOwvHJNy60V93wy0A@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ee074a99-2106-41ae-a8d6-08d5437ad388
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2017 05:15:15.5250
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 17b76cff-50c6-4f7a-9198-dd4afc5f8bea
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BM1PR0101MB1444
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBF5FUBn017605
Content-Length: 1421
Lines: 41

Hi Andy Shevchenko,

Thanks for the review.
________________________________________
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Thursday, December 14, 2017 11:29 PM
> To: Dhaval Shah
> Cc: Matthew Garrett; Pali Roh?r; Andy Shevchenko; Platform Driver; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 0/3] platform/x86: dell-laptop: All the warnings are resolved.
> 
> On Wed, Dec 13, 2017 at 10:13 AM, Dhaval Shah
> <dhaval.shah@softnautics.com> wrote:
> > There are total three types of warnings are resolved.
> > First patch  : Block comments use * on subsequent lines
> > Second patch : Missing a blank line after declarations
> > third patch  : braces {} are not necessary for single statement blocks.
> >
> 
> Can we survive without this? Does it break build or alike?
> 
Yes. We can survive without this. It will not break build or alike. This changes will not affects the functionality of the code.
But, it overall improves the code readability.
> 
> > Dhaval Shah (3):
> >   platform/x86: dell-laptop: Block comments use * on subsequent lines
> >   platform/x86: dell-laptop: Missing a blank line after declarations
> >   platform/x86: dell-laptop: braces {} are not necessary for single
> >     statement blocks
> >
> >  drivers/platform/x86/dell-laptop.c | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > --
> > 2.11.0
> >


--
With Best Regards,
Andy Shevchenko