Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752140AbdLOFRy (ORCPT ); Fri, 15 Dec 2017 00:17:54 -0500 Received: from mail-bo1ind01on0107.outbound.protection.outlook.com ([104.47.101.107]:63982 "EHLO IND01-BO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751136AbdLOFRv (ORCPT ); Fri, 15 Dec 2017 00:17:51 -0500 From: Dhaval Shah To: Andy Shevchenko CC: =?iso-8859-1?Q?Pali_Roh=E1r?= , Mario Limonciello , "dvhart@infradead.org" , Andy Shevchenko , Platform Driver , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] platform/x86: dell-smbios: Block comments use * on subsequent lines Thread-Topic: [PATCH] platform/x86: dell-smbios: Block comments use * on subsequent lines Thread-Index: AQHTc+tY2hzCwVbzXUGL7ar38FUPfaNDIqGAgAC9FBY= Date: Fri, 15 Dec 2017 05:17:48 +0000 Message-ID: References: <20171213082105.23082-1-dhaval.shah@softnautics.com>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [219.65.63.222] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BM1PR0101MB1444;6:E+uMnDmWlIvf+h57TeNNL7hysACQB+MfySB3hkrjliuwjNrI5aM98rgQxTdamFeui/OZcZhsKYmTKUrr0ZpftbZXTG3I/vFxPq91ibW8QnJtSNrqAQZO/+l9HRX9QIaSx9CqB2shinpWLAtB4PM67uS+qJo/jk2yKqfd3HChh6TdOrnkHXg1sn72l+csWBHks3+GyPrqjbxKWVSrmKF4dpaWmygLQQNAj8zxYUdEqLY++wdFgpN8L8s3lINF06ybT+6hnfcZqES3Rxec8rHGqMjj1VxCbSvYYa95CcxIR+IiTYNKD7KlzDdJVnPYV82e50PaO7mdahBvppz1cPb4HYJ4skOS3LikwLDU0ynagFg=;5:EubQu0Q3dCB9UQSQ0tnjexQTinb9/YCqKp2K+azsiU70jBfZld2cq5Ima5g35AORZxtzny3jn+I9nwsAllGD+x00AjdCF6/ImzL/4bD2pH6OEVNzCOWyFEZ2DSfDw3Ub/53DX8TaBYfMVHWZOeH7ikKh6F10S+dSwJiQbkmz2Z4=;24:08IdFqUbO5OXSMPiKHdtGlxIwBu0Qx9XGR5g6yVzoW5MP6IH5FeMvZVhWYERTuqDMNbiOq07LBodS5a67FNDtgLX6tm4QnHv35On+i5B7kk=;7:1nhd3jEDnsbkztBHbme9qQCebvGDqABUNVNLtJmvoYbrg5/9Mbsi9S2fArxehJK5FsGMKK3KfZpR/HQEvstrR3k1hYn5CEpDQ+cSKanT9EZn/6SJ0t+hXzpDvJdE5FvUyPU5yEvsMbw3ehTbTeLvUowrAe+6QQZD+wCEtbAWTLmDf21MspF2Txdez8PKqYzvIQpv6ASsfCLiFBOL7EfG4+f0OExJi5jWlS1YLC055/0drlEU6WOsTRmOXNgO9/rM x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: aa605e77-8088-4927-3d83-08d5437b2e73 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4603075)(4627115)(201702281549075)(5600026)(4604075)(2017052603307);SRVR:BM1PR0101MB1444; x-ms-traffictypediagnostic: BM1PR0101MB1444: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dhaval.shah@softnautics.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3231022)(3002001)(10201501046)(93006095)(93001095)(6041248)(20161123555025)(20161123562025)(2016111802025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(6072148)(6043046)(201708071742011);SRVR:BM1PR0101MB1444;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BM1PR0101MB1444; x-forefront-prvs: 05220145DE x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(39830400003)(346002)(396003)(376002)(24454002)(189003)(199004)(6246003)(39060400002)(97736004)(305945005)(54906003)(102836003)(99286004)(4326008)(3660700001)(68736007)(5250100002)(478600001)(9686003)(76176011)(229853002)(6436002)(33656002)(2906002)(53546011)(105586002)(86362001)(3280700002)(2900100001)(2950100002)(81166006)(74316002)(66066001)(6116002)(8936002)(6916009)(14454004)(7696005)(3846002)(7736002)(81156014)(53936002)(8676002)(59450400001)(5660300001)(106356001)(316002)(6506007)(55016002)(8666007)(25786009);DIR:OUT;SFP:1102;SCL:1;SRVR:BM1PR0101MB1444;H:BM1PR0101MB1444.INDPRD01.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 X-OriginatorOrg: softnautics.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa605e77-8088-4927-3d83-08d5437b2e73 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2017 05:17:48.0885 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 17b76cff-50c6-4f7a-9198-dd4afc5f8bea X-MS-Exchange-Transport-CrossTenantHeadersStamped: BM1PR0101MB1444 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBF5HvdQ018373 Content-Length: 1586 Lines: 48 Hi Andy Shevchenko, ________________________________________ > From: Andy Shevchenko > Sent: Thursday, December 14, 2017 11:29 PM > To: Dhaval Shah > Cc: Pali Roh?r; Mario Limonciello; dvhart@infradead.org; Andy Shevchenko; Platform Driver; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] platform/x86: dell-smbios: Block comments use * on subsequent lines > > On Wed, Dec 13, 2017 at 10:21 AM, Dhaval Shah > wrote: > > Resolved Block comments use * on subsequent lines checkpatch warnings. > > Issue found by checkpatch. > > > > Same comments as for the other like this > This changes will not affect the functionality but improves the code readability. > > Signed-off-by: Dhaval Shah > > --- > > drivers/platform/x86/dell-smbios.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c > > index 6a60db515bda..25a296c90e08 100644 > > --- a/drivers/platform/x86/dell-smbios.c > > +++ b/drivers/platform/x86/dell-smbios.c > > @@ -353,7 +353,8 @@ static void __init parse_da_table(const struct dmi_header *dm) > > container_of(dm, struct calling_interface_structure, header); > > > > /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least > > - 6 bytes of entry */ > > + * 6 bytes of entry > > + */ > > > > if (dm->length < 17) > > return; > > -- > > 2.11.0 > > -- With Best Regards, Andy Shevchenko