Subject: Re: [PATCH net-next] net/ncsi: Don't take any action on HNCDSC AEN
To: Samuel Mendoza-Jonas <sam@mendozajonas.com>, netdev@vger.kernel.org
Cc: openbmc@lists.ozlabs.org, "David S . Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org, Brian J King <bjking1@us.ibm.com>
References: <20171215051640.10926-1-sam@mendozajonas.com>
From: Jeremy Kerr <jk@ozlabs.org>
Message-ID: <fe1916de-5eb0-6084-c528-822d06c652e0@ozlabs.org>
Date: Fri, 15 Dec 2017 14:06:45 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171215051640.10926-1-sam@mendozajonas.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 984
Lines: 27

Hi Sam,

> The current HNCDSC handler takes the status flag from the AEN packet and
> will update or change the current channel based on this flag and the
> current channel status.
> 
> However the flag from the HNCDSC packet merely represents the host link
> state. While the state of the host interface is potentially interesting
> information it should not affect the state of the NCSI link. Indeed the
> NCSI specification makes no mention of any recommended action related to
> the host network controller driver state.

Yep, sounds good to me. If the link status does change, we should see an
separate AEN for that event.

Acked-by: Jeremy Kerr <jk@ozlabs.org>

However: we're looking at some behaviour of Broadcom NICs at the moment,
where the phy will be reset on link change events. We'd want to make
sure that we're not just seeing the HNCDSC events for that too. I'd
suggest we also get an Ack from Brian (CCed) to make sure we're not
breaking that case.

Cheers,


Jeremy