Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754012AbdLOG0g (ORCPT ); Fri, 15 Dec 2017 01:26:36 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:11941 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753173AbdLOG0d (ORCPT ); Fri, 15 Dec 2017 01:26:33 -0500 From: Yunlong Song To: , , , , CC: , , , , , , Subject: [PATCH] fsck.f2fs: check nid range before use to avoid segmentation fault Date: Fri, 15 Dec 2017 14:26:14 +0800 Message-ID: <1513319174-114303-1-git-send-email-yunlong.song@huawei.com> X-Mailer: git-send-email 1.8.5.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.107.193.250] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.5A336B16.002F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 7a4d0efa5d72c112994f820f0d6c029b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 953 Lines: 36 Signed-off-by: Yunlong Song --- fsck/fsck.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fsck/fsck.c b/fsck/fsck.c index 11b8b0b..2212aa3 100644 --- a/fsck/fsck.c +++ b/fsck/fsck.c @@ -14,6 +14,15 @@ char *tree_mark; uint32_t tree_mark_size = 256; +static inline int check_nid_range(struct f2fs_sb_info *sbi, nid_t nid) +{ + if (nid < F2FS_ROOT_INO(sbi)) + return -EINVAL; + if (nid >= NM_I(sbi)->max_nid) + return -EINVAL; + return 0; +} + int f2fs_set_main_bitmap(struct f2fs_sb_info *sbi, u32 blk, int type) { struct f2fs_fsck *fsck = F2FS_FSCK(sbi); @@ -740,7 +749,7 @@ void fsck_chk_inode_blk(struct f2fs_sb_info *sbi, u32 nid, for (idx = 0; idx < 5; idx++) { u32 nid = le32_to_cpu(node_blk->i.i_nid[idx]); - if (nid != 0) { + if (nid != 0 && !check_nid_range(sbi, nid)) { struct node_info ni; get_node_info(sbi, nid, &ni); -- 1.8.5.2