Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755011AbdLOJCJ (ORCPT ); Fri, 15 Dec 2017 04:02:09 -0500 Received: from ozlabs.org ([103.22.144.67]:52645 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754070AbdLOJCH (ORCPT ); Fri, 15 Dec 2017 04:02:07 -0500 From: Michael Ellerman To: Kees Cook , Michal Hocko Cc: Linux API , Khalid Aziz , Andrew Morton , Russell King - ARM Linux , Andrea Arcangeli , Linux-MM , LKML , linux-arch , Florian Weimer , John Hubbard , Matthew Wilcox , Abdul Haleem , Joel Stanley , Michal Hocko Subject: Re: [PATCH v2 0/2] mm: introduce MAP_FIXED_SAFE In-Reply-To: References: <20171213092550.2774-1-mhocko@kernel.org> Date: Fri, 15 Dec 2017 20:02:04 +1100 Message-ID: <876098ictv.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 28 Kees Cook writes: > On Wed, Dec 13, 2017 at 1:25 AM, Michal Hocko wrote: >> >> Hi, >> I am resending with some minor updates based on Michael's review and >> ask for inclusion. There haven't been any fundamental objections for >> the RFC [1] nor the previous version [2]. The biggest discussion >> revolved around the naming. There were many suggestions flowing >> around MAP_REQUIRED, MAP_EXACT, MAP_FIXED_NOCLOBBER, MAP_AT_ADDR, >> MAP_FIXED_NOREPLACE etc... > > With this named MAP_FIXED_NOREPLACE (the best consensus we've got on a > name), please consider this series: > > Acked-by: Kees Cook I don't feel like I'm actually qualified to ack the mm and binfmt changes, but everything *looks* correct to me, and you've fixed the flag numbering such that it can go in mman-common.h as I suggested. So if the name was MAP_FIXED_NOREPLACE I would also be happy with it. Acked-by: Michael Ellerman I can resubmit with the name changed if that's what it takes. cheers