Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755337AbdLOJXU (ORCPT ); Fri, 15 Dec 2017 04:23:20 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58412 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755064AbdLOJXQ (ORCPT ); Fri, 15 Dec 2017 04:23:16 -0500 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, weiping zhang , Cornelia Huck , "Michael S. Tsirkin" Subject: [PATCH 3.18 08/64] virtio: release virtio index when fail to device_register Date: Fri, 15 Dec 2017 10:21:32 +0100 Message-Id: <20171215092212.353253337@linuxfoundation.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20171215092212.018372669@linuxfoundation.org> References: <20171215092212.018372669@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 914 Lines: 31 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: weiping zhang commit e60ea67bb60459b95a50a156296041a13e0e380e upstream. index can be reused by other virtio device. Signed-off-by: weiping zhang Reviewed-by: Cornelia Huck Signed-off-by: Michael S. Tsirkin Signed-off-by: Greg Kroah-Hartman --- drivers/virtio/virtio.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -268,6 +268,8 @@ int register_virtio_device(struct virtio /* device_register() causes the bus infrastructure to look for a * matching driver. */ err = device_register(&dev->dev); + if (err) + ida_simple_remove(&virtio_index_ida, dev->index); out: if (err) add_status(dev, VIRTIO_CONFIG_S_FAILED);