Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755293AbdLOLr1 (ORCPT ); Fri, 15 Dec 2017 06:47:27 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:34816 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754389AbdLOLrX (ORCPT ); Fri, 15 Dec 2017 06:47:23 -0500 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Date: Fri, 15 Dec 2017 11:46:06 +0000 From: Charles Keepax To: Mark Brown CC: Olivier Moysan , , , , , , , , , , , , Subject: Re: [RFC PATCH 2/2] ASoC: select sysclk clock from mlck clock provider in wm8994 driver Message-ID: <20171215114606.6wxw2m5rykmb7ak2@localhost.localdomain> References: <1513270438-18523-1-git-send-email-olivier.moysan@st.com> <1513270438-18523-3-git-send-email-olivier.moysan@st.com> <20171214173624.GM9788@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20171214173624.GM9788@sirena.org.uk> User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=586 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712150167 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 555 Lines: 15 On Thu, Dec 14, 2017 at 05:36:24PM +0000, Mark Brown wrote: > On Thu, Dec 14, 2017 at 05:53:58PM +0100, Olivier Moysan wrote: > > When defined in device tree, MCLK1 and MCLK2 are used > > as sysclk for aif1 and aif2 interfaces respectively. > > That's not a valid assumption as far as I remember? The AIFs can use > either MCLK depending on the system configuration I think. > Indeed yes the code added here is literally just above the code that selects that, it should be fairly simple to update the patch to take this into account. Thanks, Charles