Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755360AbdLOLxt (ORCPT ); Fri, 15 Dec 2017 06:53:49 -0500 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:57002 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755222AbdLOLxs (ORCPT ); Fri, 15 Dec 2017 06:53:48 -0500 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Date: Fri, 15 Dec 2017 11:51:22 +0000 From: Charles Keepax To: Mark Brown CC: Olivier Moysan , , , , , , , , , , , , Subject: Re: [RFC PATCH 1/2] ASoC: add support of mclk clock providers in wm8894 driver Message-ID: <20171215115122.ckxgoqzlliufz7cm@localhost.localdomain> References: <1513270438-18523-1-git-send-email-olivier.moysan@st.com> <1513270438-18523-2-git-send-email-olivier.moysan@st.com> <20171214173025.GL9788@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20171214173025.GL9788@sirena.org.uk> User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=750 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712150167 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 603 Lines: 17 On Thu, Dec 14, 2017 at 05:30:25PM +0000, Mark Brown wrote: > On Thu, Dec 14, 2017 at 05:53:57PM +0100, Olivier Moysan wrote: > > > + pdata->mclk1 = devm_clk_get(wm8994->dev, "MCLK1"); > > + if (IS_ERR(pdata->mclk1)) > > + pdata->mclk1 = NULL; > > These should special case -EPROBE_DEFER so we defer properly if we need > to (and ideally log an error in case there was a MCLK and we legit ran > into an error). We probably want the special case on there being no clock at all which should silently proceed as this code does and then actual errors and PROBE_DEFERs can log and fail. Thanks, Charles