Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755334AbdLOM0W (ORCPT ); Fri, 15 Dec 2017 07:26:22 -0500 Received: from mx2.suse.de ([195.135.220.15]:49430 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755064AbdLOM0S (ORCPT ); Fri, 15 Dec 2017 07:26:18 -0500 Subject: Re: [PATCH v5 7/7] scsi: libsas: notify event PORTE_BROADCAST_RCVD in sas_enable_revalidation() To: Jason Yan , martin.petersen@oracle.com, jejb@linux.vnet.ibm.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, john.garry@huawei.com, zhaohongjiang@huawei.com, hare@suse.com, dan.j.williams@intel.com, jthumshirn@suse.de, Raj.Dinesh@microsemi.com, hch@lst.de, huangdaode@hisilicon.com, chenxiang66@hisilicon.com, xiyou.wangcong@gmail.com, Ewan Milne , Tomas Henzl References: <20171208094210.24887-1-yanaijie@huawei.com> <20171208094210.24887-8-yanaijie@huawei.com> From: Hannes Reinecke Message-ID: <9025ef90-943c-3682-a818-e84ad770c8dd@suse.de> Date: Fri, 15 Dec 2017 13:26:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171208094210.24887-8-yanaijie@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2167 Lines: 58 On 12/08/2017 10:42 AM, Jason Yan wrote: > There are two places queuing the disco event DISCE_REVALIDATE_DOMAIN. > One is in sas_porte_broadcast_rcvd() and uses sas_chain_event() to queue > the event. The other is in sas_enable_revalidation() and uses > sas_queue_event() to queue the event. We have diffrent work queues for > event and discovery now, so the DISCE_REVALIDATE_DOMAIN event may be > processed in both event queue and discovery queue. > > Now since we do synchronous event handling, we cannot do it in discovery > queue, so have to trigger a fake broadcast event to re-trigger the > revalidation from event queue. > > Signed-off-by: Jason Yan > CC: John Garry > CC: Johannes Thumshirn > CC: Ewan Milne > CC: Christoph Hellwig > CC: Tomas Henzl > CC: Dan Williams > --- > drivers/scsi/libsas/sas_event.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/libsas/sas_event.c b/drivers/scsi/libsas/sas_event.c > index 8c82c00..ae923eb 100644 > --- a/drivers/scsi/libsas/sas_event.c > +++ b/drivers/scsi/libsas/sas_event.c > @@ -116,11 +116,17 @@ void sas_enable_revalidation(struct sas_ha_struct *ha) > struct asd_sas_port *port = ha->sas_port[i]; > const int ev = DISCE_REVALIDATE_DOMAIN; > struct sas_discovery *d = &port->disc; > + struct asd_sas_phy *sas_phy; > > if (!test_and_clear_bit(ev, &d->pending)) > continue; > > - sas_queue_event(ev, &d->disc_work[ev].work, ha); > + if (list_empty(&port->phy_list)) > + continue; > + > + sas_phy = container_of(port->phy_list.next, struct asd_sas_phy, > + port_phy_el); > + ha->notify_port_event(sas_phy, PORTE_BROADCAST_RCVD); > } > mutex_unlock(&ha->disco_mutex); > } > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)