Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756112AbdLONRo (ORCPT <rfc822;w@1wt.eu>);
        Fri, 15 Dec 2017 08:17:44 -0500
Received: from mout.kundenserver.de ([212.227.126.133]:62793 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755482AbdLONRl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 15 Dec 2017 08:17:41 -0500
Subject: Re: [PATCH 03/25] arm: bcm: dts: Remove leading 0x and 0s from
 bindings notation
To: Mathieu Malaterre <malat@debian.org>, Rob Herring <robh+dt@kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org,
        Scott Branden <sbranden@broadcom.com>, Ray Jui <rjui@broadcom.com>,
        Russell King <linux@armlinux.org.uk>, linux-kernel@vger.kernel.org,
        Jon Mason <jonmason@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com,
        linux-arm-kernel@lists.infradead.org, Eric Anholt <eric@anholt.net>
References: <20171215124628.30029-1-malat@debian.org>
From: Stefan Wahren <stefan.wahren@i2se.com>
Message-ID: <4642ee3f-ee51-91ed-5e34-883c1906dfd7@i2se.com>
Date: Fri, 15 Dec 2017 14:16:58 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171215124628.30029-1-malat@debian.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Provags-ID: V03:K0:DmuffcapzpFbCIoqEgLYILly7SAGizrJ+LVpJFPt9zPEOrCMI9K
 9bCOHi326CMBjNW2SzrGgoTym1F7QXUcZ0Riz5Ydml6GolWvFHJzBMhD7759QU3la84Jt9p
 r4w7AoGJVZ2osR/Rq49MWItdwWmEy499bZ4rqVBVFVh6dgQB7cwtdu5cPtP78yAoPudkfXY
 CuvlCL6xHzwC8r7AgZHtA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:eAbvvTNXaC0=:OsT+lSBwSoCpYI1uhIdwmv
 GPMRUZ1Y4mHjpH0ZoMpDWq3qthQZdRRgBU95g5WFViSgBHEPVEqwKZWB4NpJaBugkzuTUBQlU
 gOO/5LTaSF0o/5BVYdCe8GtEyXf6uo3qMvivGgyIpUO5AEMNK8Ux4jLQAye6m14hWNIttmpmY
 FoBPyhEaXNa8Qq0EGoholPrkiX70LdeIz0NfaiZoTkMwTzCipG+bLc1p/jNFcOOx550CFD+cm
 SHDQuA5M8zL6oAStJGfXgi5l75BRaylfR9oVtm2BSK+OiEVA7v7KGqUHrId4W8444pCbjW8RX
 MWivOcWKY6l0piO7SSuG0jlxqXbmFAi4cSg1UVBe+CwkR73RQwxjNoaub3xy1otnQkpfIbCT2
 tga92QF+z0u98O05ndEAfK/4D7O10zIyvxg0+gIOIT8tdMcMDC42x+1KmMPc0UKUuAEgAwZbg
 oVxs+MvOqD9rHwQ8u9k+9yRFpCQofV3pk2yH7UqJ9+TSfpcZ12Nfa2NAXjJRdmkWi6rHyeYb1
 sgFiUgvllGqbsKiqCBOZlI7KL1wx0tIVja2iZoQgHAiaTQywv/ayeQyHXgQEhDzEPICEHvLrq
 +56kF05b0TtUwHw/ydEEZIx6Z47XYDlJgp0sJr7IeQFg5FrpNlujasx6h0MR1NFHMtctc7M6l
 0BBeYhZkaDAojLeduFXyF2Fq7rcBmxfTS9fDWexkJQjGut4MyPKw23wOU5BLC2bakfOX7fZNs
 zkI8owh5r8rR6XUoVn16v1vlerXEgpRhMLyl1PfeAN6tnydf2NBBVtlqvyQ=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1628
Lines: 45

[Add Eric]

Am 15.12.2017 um 13:46 schrieb Mathieu Malaterre:
> Improve the DTS files by removing all the leading "0x" and zeros to fix the
> following dtc warnings:
>
> Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
>
> and
>
> Warning (unit_address_format): Node /XXX unit name should not have leading 0s
>
> Converted using the following command:
>
> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C
>
> For simplicity, two sed expressions were used to solve each warnings separately.
>
> To make the regex expression more robust a few other issues were resolved,
> namely setting unit-address to lower case, and adding a whitespace before the
> the opening curly brace:
>
> https://elinux.org/Device_Tree_Linux#Linux_conventions
>
> This will solve as a side effect warning:
>
> Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"
>
> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
>
> Reported-by: David Daney <ddaney@caviumnetworks.com>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
>   arch/arm/boot/dts/bcm11351.dtsi | 2 +-
>   arch/arm/boot/dts/bcm21664.dtsi | 2 +-
>   arch/arm/boot/dts/bcm283x.dtsi  | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>

only for bcm283x.dtsi

@Florian: I assume this should go through your tree directly.