Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756232AbdLONay (ORCPT ); Fri, 15 Dec 2017 08:30:54 -0500 Received: from mail-qt0-f175.google.com ([209.85.216.175]:37947 "EHLO mail-qt0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755683AbdLONav (ORCPT ); Fri, 15 Dec 2017 08:30:51 -0500 X-Google-Smtp-Source: ACJfBovxAq1QFETnI7TbQJywXOxMvZxG/ja+vMSAVVeI6EYEtnKJykcMtaHdEwoAKuexXVUZN0yGug== Date: Fri, 15 Dec 2017 05:30:48 -0800 From: "tj@kernel.org" To: Bart Van Assche Cc: "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "linux-block@vger.kernel.org" , "kernel-team@fb.com" , "oleg@redhat.com" , "hch@lst.de" , "axboe@kernel.dk" , "jianchao.w.wang@oracle.com" , "osandov@fb.com" Subject: Re: [PATCH 2/6] blk-mq: replace timeout synchronization with a RCU and generation based scheme Message-ID: <20171215133048.GI3919388@devbig577.frc2.facebook.com> References: <20171212190134.535941-1-tj@kernel.org> <20171212190134.535941-3-tj@kernel.org> <1513277469.2475.43.camel@wdc.com> <20171214191935.GB3919388@devbig577.frc2.facebook.com> <1513286010.2475.58.camel@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513286010.2475.58.camel@wdc.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 518 Lines: 17 Hello, Bart. On Thu, Dec 14, 2017 at 09:13:32PM +0000, Bart Van Assche wrote: ... > however is called before a every use of a request. Sorry but I'm not > enthusiast about the code in blk_rq_init() that reinitializes state > information that should survive request reuse. If it wasn't clear, me neither. I think what'd be better is making those paths use the usual request allocation path instead of custom one but for flush handling, that's not gonna be trivial, so let's deal with that later. Thanks. -- tejun