Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932072AbdLOOCY (ORCPT ); Fri, 15 Dec 2017 09:02:24 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35825 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755628AbdLOOCW (ORCPT ); Fri, 15 Dec 2017 09:02:22 -0500 X-Google-Smtp-Source: ACJfBovz1y0sdwB9LSkcXIB5cg1p8kQrHdzhKCibP/uQa4ihiWXl9sFdkwAm/3RWhX2f74DC+Plxbk2cbakGXjJCx0o= MIME-Version: 1.0 In-Reply-To: <20171215111050.GA30737@wolff.to> References: <20171214082452.GA16698@wolff.to> <20171214100927.GA26167@localhost.didichuxing.com> <20171214154136.GA12936@wolff.to> <20171215014417.GA17757@wolff.to> <20171215111050.GA30737@wolff.to> From: weiping zhang Date: Fri, 15 Dec 2017 22:02:20 +0800 Message-ID: Subject: Re: Regression with a0747a859ef6 ("bdi: add error handle for bdi_debug_register") To: Bruno Wolff III Cc: Laura Abbott , Jan Kara , Jens Axboe , linux-mm@kvack.org, Linux Kernel Mailing List , regressions@leemhuis.info, linux-block@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 21 2017-12-15 19:10 GMT+08:00 Bruno Wolff III : > On Fri, Dec 15, 2017 at 10:04:32 +0800, > weiping zhang wrote: >> >> I just want to know WARN_ON WHAT in device_add_disk, >> if bdi_register_owner return error code, it may fail at any step of >> following: > > > Was that output in the original boot log? I didn't see anything there that > had the string WARN_ON. The first log was from a Fedora kernel. The second Sorry to let you confuse, WARN_ON means we catch log as following: WARNING: CPU: 3 PID: 3486 at block/genhd.c:680 device_add_disk+0x3d9/0x460 > from a kernel I built. I used a Fedora config though. The config was > probably from one of their nodebug kernels, I could build another one using > a config from a debug kernel. Would that likely provide what you are looking > for? Yes, please help reproduce this issue include my debug patch. Reproduce means we can see WARN_ON in device_add_disk caused by failure of bdi_register_owner.