Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756837AbdLOQ1i (ORCPT ); Fri, 15 Dec 2017 11:27:38 -0500 Received: from mail-it0-f66.google.com ([209.85.214.66]:41110 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756739AbdLOQ1f (ORCPT ); Fri, 15 Dec 2017 11:27:35 -0500 X-Google-Smtp-Source: ACJfBovUKUlrCvxMxZ0XcUAIB6CmqXKu6jLPrLGo4q7dP0J+J/EXbIJK3iDhswukN9cvPVF7hE4SFdhKnIB3nRqZeyM= MIME-Version: 1.0 In-Reply-To: <1513305976-20707-1-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1513305976-20707-1-git-send-email-yanhaishuang@cmss.chinamobile.com> From: William Tu Date: Fri, 15 Dec 2017 08:26:54 -0800 Message-ID: Subject: Re: [PATCH] ip_gre: fix wrong return value of erspan_rcv To: Haishuang Yan Cc: "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Linux Kernel Network Developers , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 558 Lines: 14 On Thu, Dec 14, 2017 at 6:46 PM, Haishuang Yan wrote: > If pskb_may_pull return failed, return PACKET_REJECT instead of -ENOMEM. > > Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN") > Cc: William Tu > Signed-off-by: Haishuang Yan > --- Thanks for the patch. I think the other way is simply to just 'goto drop', freeing the skb in erspan_rcv(), instead of 'return PACKET_REJECT'. I'm ok either way. Acked-by: William Tu