Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932650AbdLOQ6j (ORCPT ); Fri, 15 Dec 2017 11:58:39 -0500 Received: from mail-ot0-f194.google.com ([74.125.82.194]:35717 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932555AbdLOQ6h (ORCPT ); Fri, 15 Dec 2017 11:58:37 -0500 X-Google-Smtp-Source: ACJfBos5GOFuC//auhje2ujMttvdhWz+VTlRchGsHKBzY46xKhJ8XpbKGUKYg1Q6tWjXvm+0ivTalAGv6KCK6dzeL74= MIME-Version: 1.0 In-Reply-To: <1780732.fBLghQceHc@bentobox> References: <20171205143514.4441-1-sven.eckelmann@openmesh.com> <2907097.8HHYkPN8Gn@bentobox> <1780732.fBLghQceHc@bentobox> From: Willem de Bruijn Date: Fri, 15 Dec 2017 11:57:55 -0500 Message-ID: Subject: Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h To: Sven Eckelmann Cc: b.a.t.m.a.n@lists.open-mesh.org, Network Development , Jiri Pirko , LKML , Eric Dumazet , "David S . Miller" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1344 Lines: 28 On Fri, Dec 15, 2017 at 6:48 AM, Sven Eckelmann wrote: > On Freitag, 15. Dezember 2017 11:32:05 CET Sven Eckelmann wrote: >> On Mittwoch, 6. Dezember 2017 11:58:14 CET Willem de Bruijn wrote: >> [...] >> > >> > --- >> > >> > MAINTAINERS | 2 +- >> > >> > include/uapi/linux/{batman_adv.h => batadv_genl.h} | 6 +++--- >> > >> >> > >> This and the previous patch changes uapi. That might break userspace >> > >> applications that rely on it. >> > > >> > > I am not aware of any application because all (alfred, batctl and some gluon >> > > integration) of them currently ship their own copy because distribution didn't >> > > catch up. And this is also the reason why I want to do it now - not later. >> > >> > That assumes that you know all applications, including those not >> > publicly available. It may be true in this instance, but it is not >> > possible to be certain. >> >> I've just talked with Simon. Because you have a problem with these two >> changes, he suggested that I should drop these two patches and merge packet.h >> with the uapi batadv genl header batman_adv.h > > No, this is also bad because batman_adv.h is MIT license and packet.h is > GPL-2. So what other name would you suggest for packet.h? batman_adv_packet.h? Sure, that sounds great. Thanks.