Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755824AbdLORUL (ORCPT ); Fri, 15 Dec 2017 12:20:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:42750 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755479AbdLORUI (ORCPT ); Fri, 15 Dec 2017 12:20:08 -0500 Date: Fri, 15 Dec 2017 18:20:06 +0100 From: Michal =?UTF-8?B?U3VjaMOhbmVr?= To: Jens Axboe , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] cdrom: wait for tray to close Message-ID: <20171215182006.68822c93@kitsune.suse.cz> In-Reply-To: References: Organization: SUSE Linux X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 492 Lines: 18 On Thu, 14 Dec 2017 16:13:52 +0100 Michal Suchanek wrote: > @@ -2312,7 +2328,8 @@ static int cdrom_ioctl_closetray(struct > cdrom_device_info *cdi) > if (!CDROM_CAN(CDC_CLOSE_TRAY)) > return -ENOSYS; > - return cdi->ops->tray_move(cdi, 0); > + > + return tray_close(cdi); This change should be skipped. drive_status is optional and tray_close relies on it. In open_for_* functions tray_close is called based on reading the status so it's ok there. Thanks Michal