Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756004AbdLORXv (ORCPT ); Fri, 15 Dec 2017 12:23:51 -0500 Received: from mail-oi0-f65.google.com ([209.85.218.65]:37195 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755835AbdLORXp (ORCPT ); Fri, 15 Dec 2017 12:23:45 -0500 X-Google-Smtp-Source: ACJfBospUlq2KyGsGk7ry+MT01m95AxiVeZmmojLTlqpo6z+udvNNsWPsh6Xn9+58kOxdJxVu127xCVdRpSUUXGWQPc= MIME-Version: 1.0 In-Reply-To: <1591888.FGtWPsc1tq@sven-edge> References: <20171205143514.4441-1-sven.eckelmann@openmesh.com> <1780732.fBLghQceHc@bentobox> <1591888.FGtWPsc1tq@sven-edge> From: Willem de Bruijn Date: Fri, 15 Dec 2017 12:23:04 -0500 Message-ID: Subject: Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h To: Sven Eckelmann Cc: b.a.t.m.a.n@lists.open-mesh.org, Eric Dumazet , Network Development , LKML , Jiri Pirko , "David S . Miller" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 681 Lines: 16 On Fri, Dec 15, 2017 at 12:18 PM, Sven Eckelmann wrote: > On Freitag, 15. Dezember 2017 11:57:55 CET Willem de Bruijn wrote: >> > No, this is also bad because batman_adv.h is MIT license and packet.h is >> > GPL-2. So what other name would you suggest for packet.h? batman_adv_packet.h? >> >> Sure, that sounds great. Thanks. > > Really? Isn't include/uapi/linux/batman_adv_packet.h looking like an accident > which never should have had happened? My only point was that renaming and modifying existing uapi files can break userspace compilation. As long as the existing files are not changed, I don't have a strong opinion on naming for new files.