Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756227AbdLOTEy (ORCPT ); Fri, 15 Dec 2017 14:04:54 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:60037 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755889AbdLOTEx (ORCPT ); Fri, 15 Dec 2017 14:04:53 -0500 Date: Fri, 15 Dec 2017 20:04:51 +0100 From: Pavel Machek To: "Keller, Jacob E" Cc: Gabriel C , kernel list , "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" Subject: Re: v4.15-rc2 on thinkpad x60: ethernet stopped working Message-ID: <20171215190451.GA14423@amd> References: <20171210083949.GA3872@amd> <02874ECE860811409154E81DA85FBB5882B5FB2A@ORSMSX115.amr.corp.intel.com> <02874ECE860811409154E81DA85FBB5882B5FB49@ORSMSX115.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q68bSM7Ycu6FN28Q" Content-Disposition: inline In-Reply-To: <02874ECE860811409154E81DA85FBB5882B5FB49@ORSMSX115.amr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1624 Lines: 61 --Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > > Any ideas ? > > > > > > Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it. > > > > > > See: > > > https://bugzilla.kernel.org/show_bug.cgi?id=3D198047 > > > > > > Fix there : > > > https://marc.info/?l=3Dlinux-kernel&m=3D151272209903675&w=3D2 > > > > > > Regards, > > > > > > Gabriel C > >=20 > > Hi, > >=20 > > Digging into this, the problem is complicated. The original bug assumed= behavior > > of the .check_for_link call, which is universally not implemented. > >=20 > > I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate si= gnaling for > > link check/link up", 2017-10-10) and find a more proper solution. > >=20 > > I don't think any other code which uses check_for_link expects the inte= rface to > > return in the way this patch attempted. > Alternatively, we can go a step farther and make sure every implementatio= n of .check_for_link follows the modified interface. >=20 We are at -rc3 now. Reverting 19110cfbb34d seems like good solution at the moment. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --Q68bSM7Ycu6FN28Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlo0HNMACgkQMOfwapXb+vIkugCgsWWuiwqOir8mnJJGEDEdaMwq vPcAoL8f5ouUV12ZNnykFxOopnWTaAw7 =/qHi -----END PGP SIGNATURE----- --Q68bSM7Ycu6FN28Q--