Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756423AbdLOTxR (ORCPT ); Fri, 15 Dec 2017 14:53:17 -0500 Received: from mail-oi0-f66.google.com ([209.85.218.66]:36065 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756370AbdLOTxO (ORCPT ); Fri, 15 Dec 2017 14:53:14 -0500 X-Google-Smtp-Source: ACJfBouAMYh0NN3SEbJNSN6SYw4UrAZFgFvOrU1NuNWGw9K1FddBccohm6xyrW9VF927XXLxuCJ47pKLV8b08wOX47M= MIME-Version: 1.0 In-Reply-To: <20171215191930.11410-1-malat@debian.org> References: <20171215124631.30132-1-malat@debian.org> <20171215191930.11410-1-malat@debian.org> From: Fabio Estevam Date: Fri, 15 Dec 2017 17:53:13 -0200 Message-ID: Subject: Re: [PATCH v3] arm: imx: dts: Use lower case for bindings notation To: Mathieu Malaterre Cc: Rob Herring , Shawn Guo , Sascha Hauer , Fabio Estevam , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1120 Lines: 24 On Fri, Dec 15, 2017 at 5:19 PM, Mathieu Malaterre wrote: > Improve the DTS files using lower case to fix the following dtc warnings: > > Warning (simple_bus_reg): Node /XXX@ simple-bus unit address format error, expected "" > > Converted using the following command: > > find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C > > For simplicity, two sed expressions were used to solve each warnings separately. > > To make the regex expression more robust a few other issues were resolved, > namely setting unit-address to lower case, and adding a whitespace before the > the opening curly brace: > > https://elinux.org/Device_Tree_Linux#Linux_conventions > > This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation") > > Reported-by: David Daney > Suggested-by: Rob Herring > Signed-off-by: Mathieu Malaterre Reviewed-by: Fabio Estevam