Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756507AbdLOVqz (ORCPT <rfc822;w@1wt.eu>);
        Fri, 15 Dec 2017 16:46:55 -0500
Received: from mail-it0-f46.google.com ([209.85.214.46]:41698 "EHLO
        mail-it0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755864AbdLOVqy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 15 Dec 2017 16:46:54 -0500
X-Google-Smtp-Source: ACJfBovloWsceVubyj7GxvNOGbGnH5+KWFt0yS44g0qKf2re+MVEzgqWUrqo7Mgr0t/x4YRpqKWH5A==
Date: Fri, 15 Dec 2017 13:46:50 -0800 (PST)
From: David Rientjes <rientjes@google.com>
X-X-Sender: rientjes@chino.kir.corp.google.com
To: Michal Hocko <mhocko@kernel.org>
cc: Andrew Morton <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>, Oded Gabbay <oded.gabbay@gmail.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        David Airlie <airlied@linux.ie>, Joerg Roedel <joro@8bytes.org>,
        Doug Ledford <dledford@redhat.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Mike Marciniszyn <mike.marciniszyn@intel.com>,
        Sean Hefty <sean.hefty@intel.com>, Dimitri Sivanich <sivanich@sgi.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        =?UTF-8?Q?J=C3=A9r=C3=B4me_Glisse?= <jglisse@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?Q?Radim_Kr=C4=8Dm=C3=A1=C5=99?= <rkrcmar@redhat.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch v2 2/2] mm, oom: avoid reaping only for mm's with blockable
 invalidate callbacks
In-Reply-To: <20171215163534.GB16951@dhcp22.suse.cz>
Message-ID: <alpine.DEB.2.10.1712151343430.168988@chino.kir.corp.google.com>
References: <alpine.DEB.2.10.1712111409090.196232@chino.kir.corp.google.com> <alpine.DEB.2.10.1712141329500.74052@chino.kir.corp.google.com> <alpine.DEB.2.10.1712141330120.74052@chino.kir.corp.google.com> <20171215163534.GB16951@dhcp22.suse.cz>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 670
Lines: 16

On Fri, 15 Dec 2017, Michal Hocko wrote:

> > This uses the new annotation to determine if an mm has mmu notifiers with
> > blockable invalidate range callbacks to avoid oom reaping.  Otherwise, the
> > callbacks are used around unmap_page_range().
> 
> Do you have any example where this helped? KVM guest oom killed I guess?
> 

KVM is the most significant one that we are interested in, but haven't had 
sufficient time to quantify how much of an impact this has other than to 
say it will certainly be non-zero.

The motivation was more to exclude mmu notifiers that have a reason to be 
excluded rather than a blanket exemption to make the oom reaper more 
robust.