Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756689AbdLOWyT (ORCPT ); Fri, 15 Dec 2017 17:54:19 -0500 Received: from mail-ot0-f196.google.com ([74.125.82.196]:33679 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755795AbdLOWyO (ORCPT ); Fri, 15 Dec 2017 17:54:14 -0500 X-Google-Smtp-Source: ACJfBovCr9ndBwKnEKxhD4h0QqrZnu+xG6RjSifcUNQBmh5neQ7tRgtqxMnXmJswrHqajActR5mC6A== Date: Fri, 15 Dec 2017 16:54:12 -0600 From: Rob Herring To: Dan Murphy Cc: mark.rutland@arm.com, rpurdie@rpsys.net, jacek.anaszewski@gmail.com, pavel@ucw.cz, sakari.ailus@iki.fi, laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [RFC PATCH 1/2] dt: bindings: as3645a: Update dt node example with standard Message-ID: <20171215225412.x5awuc5vulornvfr@rob-hp-laptop> References: <20171212215024.30116-1-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171212215024.30116-1-dmurphy@ti.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 686 Lines: 21 On Tue, Dec 12, 2017 at 03:50:23PM -0600, Dan Murphy wrote: > Update the DT binding to remove the device name from > the DT parent node as well as removing the device > name from the label. The LED label will be generated > based off the id name stored in the local driver so > the LED function can be indicated in the label DT > entry. The subject seems incomplete "... with standard ?" > > Also removed the indentation on the example. > > Signed-off-by: Dan Murphy > --- > .../devicetree/bindings/leds/ams,as3645a.txt | 36 +++++++++++----------- > 1 file changed, 18 insertions(+), 18 deletions(-) Otherwise, Reviewed-by: Rob Herring