Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756791AbdLOW4z (ORCPT ); Fri, 15 Dec 2017 17:56:55 -0500 Received: from mail02.prevas.se ([62.95.78.10]:40381 "EHLO mail02.prevas.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756649AbdLOW4u (ORCPT ); Fri, 15 Dec 2017 17:56:50 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2F7AACoUjRa/1B8ugUNUBkBAQEBAQEBA?= =?us-ascii?q?QEBAQEHAQEBAQGJQpspmTUKhTsChUIVAQEBAQEBAQEBA4Y1AQEBAyNWEAsYAgI?= =?us-ascii?q?mAgJXBg0IAQGyI26CJ4prAQEBAQEBAQMBAQEBJIEPglqDZIISgwOBSYZpgmMFm?= =?us-ascii?q?VyJWoI7knCCFoYTi0iWdYE7NYFzTIMeglIMEIFoiz8BAQE?= X-IPAS-Result: =?us-ascii?q?A2F7AACoUjRa/1B8ugUNUBkBAQEBAQEBAQEBAQEHAQEBAQG?= =?us-ascii?q?JQpspmTUKhTsChUIVAQEBAQEBAQEBA4Y1AQEBAyNWEAsYAgImAgJXBg0IAQGyI?= =?us-ascii?q?26CJ4prAQEBAQEBAQMBAQEBJIEPglqDZIISgwOBSYZpgmMFmVyJWoI7knCCFoY?= =?us-ascii?q?Ti0iWdYE7NYFzTIMeglIMEIFoiz8BAQE?= X-IronPort-AV: E=Sophos;i="5.45,407,1508796000"; d="scan'208";a="2817062" Subject: Re: [RFC] irqchip: add support for LS1021A external interrupt lines To: Rob Herring Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Rutland , Alexander Stein , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <48d2d08c-c57a-ce49-5958-0fd5ad4a2dc7@arm.com> <1512743580-15358-1-git-send-email-rasmus.villemoes@prevas.dk> <20171212232839.yy3jtn6amktqjo4g@rob-hp-laptop> From: Rasmus Villemoes Message-ID: <62c4af0c-ffe5-23c9-9ef6-2e4b8ab90050@prevas.dk> Date: Fri, 15 Dec 2017 23:55:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20171212232839.yy3jtn6amktqjo4g@rob-hp-laptop> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1458 Lines: 42 On 2017-12-13 00:28, Rob Herring wrote: > On Fri, Dec 08, 2017 at 03:33:00PM +0100, Rasmus Villemoes wrote: >> >> .../interrupt-controller/fsl,ls1021a-extirq.txt | 19 +++ > > Please split to separate patch. Will do. >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,ls1021a-extirq.txt >> @@ -0,0 +1,19 @@ >> +* Freescale LS1021A external IRQs >> + >> +The LS1021A supports inverting the polarity of six external interrupt lines. >> + >> +Required properties: >> +- compatible: should be "fsl,ls1021a-extirq" >> +- interrupt-controller: Identifies the node as an interrupt controller >> +- #interrupt-cells: Use the same format as specified by GIC in arm,gic.txt. >> +- interrupt-parent: phandle of GIC. >> +- syscon: phandle of Supplemental Configuration Unit (scfg). > > Can this be a child of that node instead? I suppose it could, but I don't think it would make much sense. In any case, I did it this way because that seemed to be the way the syscon driver is used in lots of other cases, cf. all the occurrences of syscon_regmap_lookup_by_phandle() and the corresponding bindings - I don't think I've seen any of those cases represent the syscon-using node as a child of the syscon node. >> + >> +Example: >> + extirq: interrupt-controller@15701ac { > > Unit-address without reg is not valid. Building with W=1 will tell you > this. Thanks, that was actually a leftover from an earlier version. Rasmus