Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756639AbdLPByT (ORCPT ); Fri, 15 Dec 2017 20:54:19 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:46455 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756538AbdLPByP (ORCPT ); Fri, 15 Dec 2017 20:54:15 -0500 X-Google-Smtp-Source: ACJfBovKSOLgZJrdyMfB70DRlwxoVcd2LMVrqKAFrmSzMCY3oWDlMXMXQvqez9MzY5lw/mNAdK1Sq5JJiIc2ZxFA/7s= MIME-Version: 1.0 In-Reply-To: <20171215202936.28226-5-jarkko.sakkinen@linux.intel.com> References: <20171215202936.28226-1-jarkko.sakkinen@linux.intel.com> <20171215202936.28226-5-jarkko.sakkinen@linux.intel.com> From: Philippe Ombredanne Date: Sat, 16 Dec 2017 02:53:33 +0100 Message-ID: Subject: Re: [PATCH v8 4/8] intel_sgx: driver for Intel Software Guard Extensions To: Jarkko Sakkinen , Suresh Siddha Cc: intel-sgx-kernel-dev@lists.01.org, platform-driver-x86@vger.kernel.org, x86@kernel.org, LKML , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Darren Hart , Andy Shevchenko , Vinod Koul , jessica.marz@intel.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3636 Lines: 89 Jarkko, Suresh, On Fri, Dec 15, 2017 at 9:27 PM, Jarkko Sakkinen wrote: > Intel SGX is a set of CPU instructions that can be used by applications > to set aside private regions of code and data. The code outside the > enclave is disallowed to access the memory inside the enclave by the CPU > access control. [...] > Signed-off-by: Jarkko Sakkinen > Tested-by: Serge Ayoun [...] > --- /dev/null > +++ b/arch/x86/include/asm/sgx.h > @@ -0,0 +1,233 @@ > +/* > + * This file is provided under a dual BSD/GPLv2 license. When using or > + * redistributing this file, you may do so under either license. > + * > + * GPL LICENSE SUMMARY > + * > + * Copyright(c) 2016-2017 Intel Corporation. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of version 2 of the GNU General Public License as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + * > + * Contact Information: > + * Jarkko Sakkinen > + * Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo > + * > + * BSD LICENSE > + * > + * Copyright(c) 2016-2017 Intel Corporation. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of Intel Corporation nor the names of its > + * contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + * > + * Authors: > + * > + * Jarkko Sakkinen > + * Suresh Siddha > + */ Would you be kind enough to use the SPDX tags instead of this fine but super long (40+ lines) legalese? This is the new way as documented in Thomas [1] patches and already adopted by other Intel contributors. Thank you for your kind consideration! [1] https://lkml.org/lkml/2017/12/4/934 CC: Vinod Koul CC: Jessica Marz -- Cordially Philippe Ombredanne