Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756824AbdLPExT (ORCPT ); Fri, 15 Dec 2017 23:53:19 -0500 Received: from muin.pair.com ([209.68.1.55]:50714 "EHLO muin.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756380AbdLPExN (ORCPT ); Fri, 15 Dec 2017 23:53:13 -0500 Subject: Re: [PATCH v3 00/11] ASoC: fsl_ssi: Clean up - coding style level To: Nicolin Chen , broonie@kernel.org Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, fabio.estevam@nxp.com, mail@maciej.szmigiero.name, caleb@crome.org, lgirdwood@gmail.com, arnaud.mouiche@invoxia.com, lukma@denx.de, kernel@pengutronix.de References: <1513207108-30430-1-git-send-email-nicoleotsuka@gmail.com> From: Timur Tabi Message-ID: <19ce4850-5561-45b1-3c16-1dd5591ab88a@tabi.org> Date: Fri, 15 Dec 2017 22:53:09 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1513207108-30430-1-git-send-email-nicoleotsuka@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 387 Lines: 9 On 12/13/17 5:18 PM, Nicolin Chen wrote: > Additionally, in order to fix/work-around hardware bugs and design > flaws, the driver made a lot of compromise so now its program flow > looks very complicated and it's getting hard to maintain or update. > > So I am going to clean up the driver on both coding style level and > program flow level. I'm okay with everything except patch #3.