Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751378AbdLPFIh (ORCPT ); Sat, 16 Dec 2017 00:08:37 -0500 Received: from mail-io0-f195.google.com ([209.85.223.195]:40778 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbdLPFIg (ORCPT ); Sat, 16 Dec 2017 00:08:36 -0500 X-Google-Smtp-Source: ACJfBosS0dg4EW54QgyvlrJN6WoaSHXVCSfNcg8A/5esCUGahMYTCHp0w1KoeF5GCvTRPEamJQZtGA== Date: Fri, 15 Dec 2017 21:08:32 -0800 From: Benson Leung To: Arnd Bergmann Cc: Benson Leung , Olof Johansson , linux-kernel@vger.kernel.org Subject: Re: [PATCH] cros_ec: fix nul-termination for firmware build info Message-ID: <20171216050832.GB79455@decatoncale.mtv.corp.google.com> References: <20171204145014.479349-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4SFOXa2GPu3tIq4H" Content-Disposition: inline In-Reply-To: <20171204145014.479349-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1840 Lines: 58 --4SFOXa2GPu3tIq4H Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Arnd, On Mon, Dec 04, 2017 at 03:49:48PM +0100, Arnd Bergmann wrote: > As gcc-8 reports, we zero out the wrong byte: >=20 > drivers/platform/chrome/cros_ec_sysfs.c: In function 'show_ec_version': > drivers/platform/chrome/cros_ec_sysfs.c:190:12: error: array subscript 42= 94967295 is above array bounds of 'uint8_t[]' [-Werror=3Darray-bounds] >=20 > This changes the code back to what it did before changing to a > zero-length array structure. >=20 > Fixes: a841178445bb ("mfd: cros_ec: Use a zero-length array for command d= ata") > Signed-off-by: Arnd Bergmann Applied. Thanks! Benson --=20 Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org --4SFOXa2GPu3tIq4H Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJaNKpQAAoJEB8J9XsKL+ZYH3QP/1IIf7lbOMBGixECztPj/jc2 Gb0T9W7DhGo9SckybSwUllArb1U7NoYTU/YhPXefcOFl4/LSJ9J2VoAKSIn4mP5d WhYs0W1b3YROIlOYpy1Ix2a7Sff7MH6axjIZoARf3g4/4hikpeB65Hv/1/D54F4O K5x2eTFfy0InIhabKUT7vE4OE1GbKYt7e4UvpQuNhxrkrsRSf4HKKE9m0KetwChY VWkhCmwHMnfmVNJyDelsnhALUfB4mVMpMrcnULY9IMUxbrhD5lg8ys62+YvZ5duJ dWQR0qJT5+9lEPasSvqOlVpvHtfYcU82joEclJPkJLaGOsH1OwzbAK611NvOLLSJ cnmZZ/+xXUt7lWH2ycbUKt3w5Bt5KYySwtsZQEbaZlGbYhSHUEj6clM7TQNnKucH Ck/9MyVw7aKfB+n34NHVo41xjKYE4+vqsr5ZWNwS3BsRS/7jdxwDW9MVGvACkZy1 Ckqsm88qgFH6dTcp/39fYiKLhjrcAP9oflyEVDDmiEd71mGH4Ac1+mYg2/b+eQX9 LrjuwS+PBgkbthJFBso6r7k2BxPbkOik5HcVs40n2EAkIUNUCloJO0xd17va1ntj F4mXQ1hGaZEZIAwLcmT7EUoEXU2nQHBK1lu24Ri7xZfCFaaA2QJ0R3wrm8wGqsUr ymkjNrhvNErJmTKddTFH =w6Q6 -----END PGP SIGNATURE----- --4SFOXa2GPu3tIq4H--