Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751710AbdLPFUq (ORCPT ); Sat, 16 Dec 2017 00:20:46 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:42683 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbdLPFUo (ORCPT ); Sat, 16 Dec 2017 00:20:44 -0500 X-Google-Smtp-Source: ACJfBovIfrTsDzybFu2MkzXwVL1wCPY7YA95Lydm6ulQpxKGLOzF+l5QF9WayVy8GA7lwn+facsoJg== Date: Fri, 15 Dec 2017 21:20:39 -0800 From: Bjorn Andersson To: Damien Riegel Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Gross , David Brown , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , kernel@savoirfairelinux.com Subject: Re: [PATCH v2 09/10] arm64: dts: qcom: msm8916: normalize I2C and SPI nodes Message-ID: <20171216052039.GF4281@tuxbook> References: <20171207151942.5805-1-damien.riegel@savoirfairelinux.com> <20171207151942.5805-10-damien.riegel@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171207151942.5805-10-damien.riegel@savoirfairelinux.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 646 Lines: 17 On Thu 07 Dec 07:19 PST 2017, Damien Riegel wrote: > The QUP core can be used either for I2C or SPI, so the same IP is mapped > by a driver or the other. SPI bindings use a leading 0 for the start > address and a size of 0x600, I2C bindings don't have the leading 0 and > have a size 0x1000. > > To make them more similar, add the leading 0 to I2C bindings and changes > the size to 0x500 for all of them, as this is the actual size of these > blocks. Also align the second entry of the clocks array. > > Signed-off-by: Damien Riegel Acked-by: Bjorn Andersson Regards, Bjorn