Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913AbdLPHks (ORCPT ); Sat, 16 Dec 2017 02:40:48 -0500 Received: from mail-pf0-f173.google.com ([209.85.192.173]:37251 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbdLPHkp (ORCPT ); Sat, 16 Dec 2017 02:40:45 -0500 X-Google-Smtp-Source: ACJfBosMhiJV5qchifZapOR2n7UTHmtilTCgew9es+z0JxCE3gbJMzb6ZW1jgws7M+kkl+IQ/hG3Qbx8+djhTBR1YAo= MIME-Version: 1.0 In-Reply-To: References: <20171214201757.5393-1-xiyou.wangcong@gmail.com> <87efnwcwd3.fsf@xmission.com> From: Dmitry Vyukov Date: Sat, 16 Dec 2017 08:40:24 +0100 Message-ID: Subject: Re: [PATCH] exit: move exit_task_namespaces() after exit_task_work() To: Cong Wang Cc: "Eric W. Biederman" , LKML , Ingo Molnar , Al Viro , Andrew Morton , Linus Torvalds , stable Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1872 Lines: 44 On Sat, Dec 16, 2017 at 1:00 AM, Cong Wang wrote: >>>>> syzbot reported we have a use-after-free when mqueue_evict_inode() >>>>> is called on __cleanup_mnt() path, where the ipc ns is already >>>>> freed by the previous exit_task_namespaces(). We can just move >>>>> it after after exit_task_work() to avoid this use-after-free. >>>> >>>> How does that possibly work. (I haven't seen this syzbot report). >>>> >>>> Looking at the code we have get_ns_from_inode. Which takes the mq_lock, >>>> sees if the pointer is NULL and takes a reference if it is non-NULL. >>>> >>>> Meanwhile put_ipc_ns calls mq_clear_sbinfo(ns) with the mq_lock held >>>> when the count drops to zero. >>>> >>>> Where is the race in that? >>>> >>>> The rest of mqueue_evict_inode uses the returned pointer and >>>> tests that the pointer is non-NULL before user it. >>>> >>>> So either szbot is giving you a bad report or there is a subtle race >>>> there I am not seeing. The change below is not at all the proper way to >>>> fix a subtle race. >>>> >>>> Eric >>> >>> Cong, what was that report? Searching by >>> "exit_task_work|exit_task_namespaces" there are too many of them: >>> https://groups.google.com/forum/#!searchin/syzkaller-bugs/%22exit_task_work$7Cexit_task_namespaces%22%7Csort:date >>> >>> I can only say that syzbot does not make up reports. That's something >>> that actually happened and was provoked by userspace. >> >> >> Ah, found that bug: >> https://groups.google.com/d/msg/syzkaller-bugs/1XBaqnPSXzs/VF-eCSPuCQAJ > > Yeah, and it is introduced by: > > http://git.cmpxchg.org/cgit.cgi/linux-mmots.git/commit/?id=9c583773d036336176e9e50441890659bc4eeae8 If it's going to be discussed here, note that it was reported by syzbot and requires "#syz fix" tag after fixing here: https://groups.google.com/d/msg/syzkaller-bugs/1XBaqnPSXzs/jGDCMoz_AQAJ