Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752655AbdLPIpd (ORCPT ); Sat, 16 Dec 2017 03:45:33 -0500 Received: from mail-wr0-f181.google.com ([209.85.128.181]:45675 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142AbdLPIpb (ORCPT ); Sat, 16 Dec 2017 03:45:31 -0500 X-Google-Smtp-Source: ACJfBos7o4lnz/wX6Fa2FaUBjVN1GBe3EwTXtkDxBNwQ94YDD1/XdBjIydtoU/pSx6jJfgqn83hEPg== From: Sven Eckelmann To: b.a.t.m.a.n@lists.open-mesh.org Cc: Willem de Bruijn , Network Development , Jiri Pirko , LKML , Eric Dumazet , Tom Herbert , "David S . Miller" Subject: Re: [B.A.T.M.A.N.] [RFC v3 0/4] flow_dissector: Provide basic batman-adv unicast handling Date: Sat, 16 Dec 2017 09:45:20 +0100 Message-ID: <2130928.Gov3uGz9Ek@sven-edge> User-Agent: KMail/5.2.3 (Linux/4.9.0-4-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: References: <20171215182313.15767-1-sven.eckelmann@openmesh.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart17600194.ePNuLTmzPI"; micalg="pgp-sha512"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1543 Lines: 39 --nextPart17600194.ePNuLTmzPI Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Freitag, 15. Dezember 2017 17:51:19 CET Willem de Bruijn wrote: [....] > Thanks for making these changes. The flow dissection looks good to me. > > One possible issue is that this exposes kernel fixed width types u8/u16/.. > to userspace. For posix compatibility reasons, uapi headers use the > variant with underscores. Thanks for the info - missed this. Kind regards, Sven --nextPart17600194.ePNuLTmzPI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAlo03SAACgkQXYcKB8Em e0YhUQ/7BY6lfN2hKcwEoNcyBdmsbIIyYwxCrh1lO112QIXQhP6E8hHSD9qWe8Cw 8Fl8qYKsJ4DNLvzMFTyh9XjAHIHyxEYOn7gwhvhphnqTn2qlXkYhHM0AqN64d1Kq egnPfaKlepLbr/x1u47Atg6KgAd6RlbILrjiVsnIniGk17Zxfjy/ZQno+UuEF8pJ A1dEb4pJCvnhk3UpLFxCgHZqlVvzwCVMrwp0xMXCugIaGJO4K2Mxe7tmM2GiAr0z TSreo6SPrMXDNQ48APLaNLV9zDWW/xLCACBLimE//3GTYSyBWjN8nJePEssQdVh7 pt+LdVS7lvC1H9sYkWHoG7SuZOKteQyTgIl9AbLxABlq9rtnQUSE539UeatgTVTb Ds7YnEOPKqJYNr4QRxsBDGrOx6YoBj2ONwZLEUSzawMQH05e0NaXR+ki6fby0xGv l5omGnvn2a3zP30vFns6sUwcXdKZSGi6biJeM+ixj/R1ujR5PL8mQGB+gy1e04YV MEw/5xnKjCdjxtNsQ3aUv0H/PSbX0mxcjmU2LiVnvwMTZk04xD4nUVGQ1A2vU6fi iWCu7gXuqlvsukgY6I7V9G0c1piiY6PIboPmEA4SjsZlscNFrfk/2pR5XXgUt/5K 7BNnlhxExyInCduVMjEOBFXLuXS1U+Rsszu8yey9svsftxfzWT0= =NhkC -----END PGP SIGNATURE----- --nextPart17600194.ePNuLTmzPI--