Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757027AbdLPODe (ORCPT ); Sat, 16 Dec 2017 09:03:34 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:38946 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756826AbdLPODa (ORCPT ); Sat, 16 Dec 2017 09:03:30 -0500 X-Google-Smtp-Source: ACJfBotAlUSU5mrYVINv2yDadLv/1M7VuRGA5P+5fCr0MZBFWlN/bchZamwtXZBzHxOrIEwgt5oEyg== Date: Sat, 16 Dec 2017 15:03:26 +0100 From: Ingo Molnar To: Dave Young Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, ard.biesheuvel@linaro.org, matt@codeblueprint.co.uk Subject: Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap Message-ID: <20171216140326.sbel3qfe4fbhaybl@gmail.com> References: <20171130052327.GA3500@dhcp-128-65.nay.redhat.com> <20171214104119.GA2437@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171214104119.GA2437@dhcp-128-65.nay.redhat.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 351 Lines: 14 * Dave Young wrote: > Another way is move "efi_memblock_x86_reserve_range" to later code > Maybe below is better? Yeah, that's much lower risk, if the affected EFI code does not mind being called later. We had trouble from trying to move early param parsing wholesale. I've applied your v2 patch tip:efi/core. Thanks, Ingo