Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756780AbdLPOTg (ORCPT ); Sat, 16 Dec 2017 09:19:36 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:43577 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753577AbdLPOTd (ORCPT ); Sat, 16 Dec 2017 09:19:33 -0500 X-Google-Smtp-Source: ACJfBot20IUawZtzHydwLrXb0Sd1nLZ43FP21ifT2kTPtSQL9BhJ9x9XpI91jnKXsqGECaQ/xLomrsmNY2d4Jdu1JNg= MIME-Version: 1.0 In-Reply-To: References: <20171206153005.6144-1-stefan@agner.ch> <20171206153005.6144-9-stefan@agner.ch> From: Philippe Ombredanne Date: Sat, 16 Dec 2017 15:18:51 +0100 Message-ID: Subject: Re: [PATCH 9/9] ARM: dts: imx7: add Toradex Colibri iMX7D 1GB (eMMC) support To: Stefan Agner Cc: Shawn Guo , Sascha Hauer , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , Rob Herring , Fabio Estevam , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Fabio Estevam Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2990 Lines: 67 Dear Stefan, On Sat, Dec 16, 2017 at 3:09 PM, Fabio Estevam wrote: > On Wed, Dec 6, 2017 at 1:30 PM, Stefan Agner wrote: > >> diff --git a/arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dts b/arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dts >> new file mode 100644 >> index 000000000000..5d5bb4c2843f >> --- /dev/null >> +++ b/arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dts >> @@ -0,0 +1,55 @@ >> +/* >> + * Copyright 2017 Toradex AG >> + * >> + * This file is dual-licensed: you can use it either under the terms >> + * of the GPL or the X11 license, at your option. Note that this dual >> + * licensing only applies to this file, and not this project as a >> + * whole. >> + * >> + * a) This file is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License >> + * version 2 as published by the Free Software Foundation. >> + * >> + * This file is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * Or, alternatively, >> + * >> + * b) Permission is hereby granted, free of charge, to any person >> + * obtaining a copy of this software and associated documentation >> + * files (the "Software"), to deal in the Software without >> + * restriction, including without limitation the rights to use, >> + * copy, modify, merge, publish, distribute, sublicense, and/or >> + * sell copies of the Software, and to permit persons to whom the >> + * Software is furnished to do so, subject to the following >> + * conditions: >> + * >> + * The above copyright notice and this permission notice shall be >> + * included in all copies or substantial portions of the Software. >> + * >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> + * OTHER DEALINGS IN THE SOFTWARE. >> + */ > > Patch looks good. > > Just a comment: people have been starting to use SPDX license identifiers. > > This would really make all this huge license text much shorter :-) Oh yes, please! Every time there are more than three lines of legalese in a kernel source code file, a kitten dies somewhere. That's sad. We all love kitten, right? See also Thomas doc patches for details [1] though he forgot to mention this cat fact. [1] https://lkml.org/lkml/2017/12/4/934 -- Cordially Philippe Ombredanne