Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757059AbdLPQ1O (ORCPT ); Sat, 16 Dec 2017 11:27:14 -0500 Received: from muin.pair.com ([209.68.1.55]:50421 "EHLO muin.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757027AbdLPQ1L (ORCPT ); Sat, 16 Dec 2017 11:27:11 -0500 Subject: Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments To: Nicolin Chen Cc: Mark Brown , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, fabio.estevam@nxp.com, mail@maciej.szmigiero.name, caleb@crome.org, lgirdwood@gmail.com, arnaud.mouiche@invoxia.com, lukma@denx.de, kernel@pengutronix.de References: <1513207108-30430-1-git-send-email-nicoleotsuka@gmail.com> <1513207108-30430-4-git-send-email-nicoleotsuka@gmail.com> From: Timur Tabi Message-ID: <3ee01787-9c38-6780-b247-b7d81769e53e@tabi.org> Date: Sat, 16 Dec 2017 10:27:06 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 611 Lines: 17 On 12/16/17 12:10 AM, Nicolin Chen wrote: > Hi, > > I am outside so can't use mutt. Sorry for that. > > This comment is going to be replaced in the 2nd set anyway because the > whole function will be replaced. So you're asking me to review comment changes that will soon be deleted? Can you send out a new patch without changes to comments, so that I can focus on the ones that matter? > And please point out all comments that you think I need to rework. I am > totally fine to do that. I don't think every single one is bad. And this > patch has to go in as it also adds a lot of new comments. Ok.