Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757123AbdLPRvZ (ORCPT ); Sat, 16 Dec 2017 12:51:25 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33748 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756689AbdLPRvW (ORCPT ); Sat, 16 Dec 2017 12:51:22 -0500 X-Google-Smtp-Source: ACJfBovU5Iwwq7P8fJXeDJr7KvJD4k+YhViFvPFqSVf/kVDftrWC5O1PFGt1/dY71SyWWZFa8RusQg== Date: Sat, 16 Dec 2017 09:51:20 -0800 From: Stephen Hemminger To: Randy Dunlap Cc: Greg KH , Vincent Legoll , devel@linuxdriverproject.org, haiyangz@microsoft.com, sthemmin@microsoft.com, Linux Kernel ML Subject: Re: [PATCH] hyperv: make HYPERV a menuconfig to ease disabling it all Message-ID: <20171216095120.568fad34@xeon-e3> In-Reply-To: References: <20171209152151.4341-1-vincent.legoll@gmail.com> <20171209215022.6795dd91@xeon-e3> <20171213132338.1efe04a7@xeon-e3> <20171214075132.GB31378@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2099 Lines: 61 On Thu, 14 Dec 2017 09:43:48 -0800 Randy Dunlap wrote: > On 12/13/2017 11:51 PM, Greg KH wrote: > > On Wed, Dec 13, 2017 at 01:23:38PM -0800, Stephen Hemminger wrote: > >> On Wed, 13 Dec 2017 09:54:19 +0100 > >> Vincent Legoll wrote: > >> > >>> Hello, > >>> > >>> On Sun, Dec 10, 2017 at 6:50 AM, Stephen Hemminger > >>> wrote: > >>>> Will this break existing configs? > >>> > >>> I don't think so. Last time I did some similar changes, the kbuild > >>> test robot found some warnings on some configurations, I hope > >>> it will find problems (if any) for that series too (this one is not alone, > >>> I've got a bunch of other similar patches in-flight) > >>> > >>> Thanks > >> > >> NAK > >> > >> Let me give a concrete example of how this will break users. > >> > >> 1. Assume user has a working .config file in their kernel build directory > >> which builds a kernel that works on Hyper-V. > >> > >> 2. Add your patch (or assume it makes into a later version). > >> > >> 3. User then does > >> > >> $ make oldconfig > >> scripts/kconfig/conf --oldconfig Kconfig > >> * > >> * Restart config... > >> * > >> * > >> * Microsoft Hyper-V guest support > >> * > >> Microsoft Hyper-V guest support (HYPERV_MENU) [N/y] (NEW) > >> > >> If they hit return, the default value is not enabling HyperV and they > >> will then go on to build a kernel that will not boot on your system. > >> > >> The default MUST be set to Yes. > > That should work. > > > Or you can just not take these types of odd and silly changes to the > > Kconfig files, and leave it as-is. I have yet to see the good reason > > why these are needed at all. > > Some of us would like to be able to disable many like drivers at one time > instead of having to go down a list of say 20-30 drivers and disable them > one at a time. > It makes sense to organize the config if you dont break old configs. It would be more logical to group and treat all para-virtualized guest support in same way. Hyper-V should be next to KVM and Xen.