Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757045AbdLPSCq (ORCPT ); Sat, 16 Dec 2017 13:02:46 -0500 Received: from smtprelay0037.hostedemail.com ([216.40.44.37]:48710 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752746AbdLPSCl (ORCPT ); Sat, 16 Dec 2017 13:02:41 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: X-HE-Tag: paint72_33ab463453317 X-Filterd-Recvd-Size: 3305 Message-ID: <1513447353.4647.39.camel@perches.com> Subject: Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program From: Joe Perches To: Stephen Hemminger , Knut Omang Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Nicolas Palix , Jonathan Corbet , Santosh Shilimkar , Matthew Wilcox , cocci@systeme.lip6.fr, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, linux-doc@vger.kernel.org, Doug Ledford , =?ISO-8859-1?Q?Micka=EBl_Sala=FCn?= , Shuah Khan , linux-kbuild@vger.kernel.org, Michal Marek , Julia Lawall , John Haxby , =?ISO-8859-1?Q?=C5smund_=D8stvold?= , Jason Gunthorpe , Masahiro Yamada , Kees Cook , netdev@vger.kernel.org, Gilles Muller , "David S. Miller" , "Paul E. McKenney" , =?ISO-8859-1?Q?H=E5kon?= Bugge , Andy Whitcroft , "Levin, Alexander (Sasha Levin)" Date: Sat, 16 Dec 2017 10:02:33 -0800 In-Reply-To: <20171216094745.5e41ac51@xeon-e3> References: <20171216094745.5e41ac51@xeon-e3> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1309 Lines: 30 On Sat, 2017-12-16 at 09:47 -0800, Stephen Hemminger wrote: > On Sat, 16 Dec 2017 15:42:25 +0100 > Knut Omang wrote: > > > This patch series implements features to make it easier to run checkers on the > > entire kernel as part of automatic and developer testing. > > > > This is done by replacing the sparse specific setup for the C={1,2} variable > > in the makefiles with setup for running scripts/runchecks, a new program that > > can run any number of different "checkers". The behaviour of runchecks is > > defined by simple "global" configuration in scripts/runchecks.cfg which can be > > extended by local configuration applying to individual files, directories or > > subtrees in the source. [] > I like the ability to add more checkers and keep then in the main > upstream tree. But adding overrides for specific subsystems goes against > the policy that all subsystems should be treated equally. > > There was discussion at Kernel Summit about how the different > subsystems already have different rules. This appears to be a > way to make that worse. I think that's OK and somewhat reasonable. What is perhaps unreasonable is requiring subsystems with a local specific style to change to some universal style. see comments like: https://lkml.org/lkml/2017/12/11/689